Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(memdb): add memdb package #18

Merged
merged 13 commits into from
Sep 18, 2022
Merged

feat(memdb): add memdb package #18

merged 13 commits into from
Sep 18, 2022

Conversation

peakji
Copy link
Member

@peakji peakji commented Sep 17, 2022

No description provided.

@peakji peakji marked this pull request as draft September 17, 2022 16:12
@codecov-commenter
Copy link

codecov-commenter commented Sep 17, 2022

Codecov Report

Base: 94.38% // Head: 91.39% // Decreases project coverage by -2.99% ⚠️

Coverage data is based on head (e017b95) compared to base (07f9d8e).
Patch coverage: 82.87% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #18      +/-   ##
==========================================
- Coverage   94.38%   91.39%   -3.00%     
==========================================
  Files          27       33       +6     
  Lines        1745     2358     +613     
==========================================
+ Hits         1647     2155     +508     
- Misses         69      139      +70     
- Partials       29       64      +35     
Impacted Files Coverage Δ
internal/engine/memdb/queue.go 68.83% <68.83%> (ø)
internal/engine/memdb/task.go 74.28% <74.28%> (ø)
internal/engine/memdb/promise.go 76.19% <76.19%> (ø)
internal/engine/memdb/topic.go 83.33% <83.33%> (ø)
internal/engine/memdb/memdb.go 97.56% <97.56%> (ø)
internal/engine/memdb/indexer.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@peakji
Copy link
Member Author

peakji commented Sep 17, 2022

TODO: benchmark count performance.
Reference: hashicorp/go-memdb#83

@peakji peakji marked this pull request as ready for review September 18, 2022 10:07
@peakji peakji merged commit 8757da8 into master Sep 18, 2022
@peakji peakji deleted the memdb branch September 18, 2022 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants