Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide on a metadata library #194

Closed
bcomnes opened this issue Jun 25, 2017 · 11 comments
Closed

Decide on a metadata library #194

bcomnes opened this issue Jun 25, 2017 · 11 comments

Comments

@bcomnes
Copy link
Contributor

bcomnes commented Jun 25, 2017

There are a few variants of metadata parsing libs in node. We should figure out which one fits our needs best.

@bcomnes
Copy link
Contributor Author

bcomnes commented Jun 25, 2017

We also may end up forking depending on how well supported these are.

@bcomnes
Copy link
Contributor Author

bcomnes commented Jun 25, 2017

@bcomnes bcomnes added the Meta label Jun 25, 2017
@bcomnes bcomnes modified the milestone: Winamp 2 Jun 25, 2017
@bcomnes
Copy link
Contributor Author

bcomnes commented Jul 12, 2017

@bcomnes
Copy link
Contributor Author

bcomnes commented Jul 31, 2017

I think using the JS libs for reading in tags will get us to 1.0.0 but we ultimately need to bind to something like http://taglib.org if we want to make this a real library. It would be a good excuse to help out with the prebuild electron ecosystem that mafintosh and ralphtheninja are working on.

@bcomnes
Copy link
Contributor Author

bcomnes commented Aug 9, 2017

I tried writing a native wrapper last night with @mafintosh but the library is all sync, and C++ makes my head spin. Maybe sticking with the JS libs would be best for now.

@zeke
Copy link
Member

zeke commented Aug 20, 2017

prebuild electron ecosystem that @mafintosh and @ralphtheninja are working on

Sounds interesting. Where can I follow along?

@bcomnes
Copy link
Contributor Author

bcomnes commented Aug 20, 2017

https://github.com/home-prebuilders-association and freenode##prebuild however there hasn't been much action lately.

@zeke
Copy link
Member

zeke commented Aug 20, 2017

haha love the name. Can I join the org? I'm no native modules expert, but I'd be glad to help out however I can.

@bcomnes
Copy link
Contributor Author

bcomnes commented Aug 20, 2017

@zeke https://github.com/mafintosh/prebuild is the only prebuilding system that seems to handle the electron use case, they do this by shipping bindings for all platforms including electron that link to a shared library (I think I used my words right here ;P). The idea is that prebuilds 'just-work' everywhere, including electron and that you aught not have to rebuild-just-for-electron despite downloading pre-builds.

Unfortunately the peeps maintaining https://github.com/mapbox/node-pre-gyp at mapbox don't do anything with electron, so popular modules that depend on pre-gyp have really poor electron support, including the popular sqlite package and mapbox doesn't seem to have the bandwidth to fix the situation either.

Here are a few longstanding issues:

If anyone on the electron team has the bandwidth to take on some saints work doing an audit of the node pre-build ecosystem so that it works better with native modules, it would be making the world a better place. I was planning on doing it a while ago, but my nose has taken me in different directions for the time being.

@bcomnes
Copy link
Contributor Author

bcomnes commented Aug 22, 2017

@zeke didn't see the request to join. I would ask @ralphtheninja I don't have membership at the moment.

@ralphtheninja
Copy link

@zeke Invited you. There's nothing there atm so not much to join :) But I'm hoping to push this in the coming weeks/months.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants