Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix weird MP3 parsing #185

Closed
bcomnes opened this issue Jun 17, 2017 · 1 comment
Closed

Fix weird MP3 parsing #185

bcomnes opened this issue Jun 17, 2017 · 1 comment
Assignees
@bcomnes
Labels
bug
Milestone
Winamp 2

Comments

@bcomnes
Copy link
Contributor

bcomnes commented Jun 17, 2017

Some of my Mp3s don't have tags or something so they don't get a length, causing all sorts of problems. Close this issue after diving into the behavior of https://github.com/hypermodules/hyperamp/blob/master/main/library.js#L48-L66 and make this a bit more robust in fail states.
@bcomnes bcomnes added the bug label Jun 17, 2017
@bcomnes bcomnes mentioned this issue Jun 25, 2017
Closed
@bcomnes bcomnes modified the milestone: Winamp 2 Jun 25, 2017
@bcomnes
Copy link
Contributor Author

bcomnes commented Oct 23, 2017

Related: #193

@bcomnes bcomnes mentioned this issue Oct 23, 2017
Closed
@bcomnes bcomnes self-assigned this Nov 6, 2017
@bcomnes bcomnes mentioned this issue Nov 9, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bcomnes bcomnes

Labels
bug
Projects
None yet
Milestone
Winamp 2
Development

No branches or pull requests
1 participant
@bcomnes