refactor: Simplify how list splits are tracked. #5920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the code keeps tracks of the split startUids and updates them as the posting lists are split or empty parts are removed. Instead, update the list of startUids at the end of each step based on the contents of the map of startUids to posting list. This removes the need of keeping track of the same piece of information in two different ways. Also, fix a bug where the empty parts were removed from the list of splits but not from the map. This caused empty posting lists to be written to disk although it didn't affect normal execution because those parts were not accessible from the main posting list.
martinmr
changed the title
ashish-goswami
approved these changes
Jul 24, 2020
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @manishrjain)
parasssh
approved these changes
Jul 24, 2020
There was a problem hiding this comment.
Reviewable status:
martinmr
added a commit
that referenced
this pull request
Jul 24, 2020
Currently the code keeps tracks of the split startUids and updates them as the posting lists are split or empty parts are removed. Instead, update the list of startUids at the end of each step based on the contents of the map of startUids to posting list. This removes the need of keeping track of the same piece of information in two different ways. Also, fix a bug where the empty parts were removed from the list of splits but not from the map. This caused empty posting lists to be written to disk although it didn't affect normal execution because those parts were not accessible from the main posting list. (cherry picked from commit c51d007)
martinmr
added a commit
that referenced
this pull request
Jul 24, 2020
Currently the code keeps tracks of the split startUids and updates them as the posting lists are split or empty parts are removed. Instead, update the list of startUids at the end of each step based on the contents of the map of startUids to posting list. This removes the need of keeping track of the same piece of information in two different ways. Also, fix a bug where the empty parts were removed from the list of splits but not from the map. This caused empty posting lists to be written to disk although it didn't affect normal execution because those parts were not accessible from the main posting list. (cherry picked from commit c51d007)
martinmr
added a commit
that referenced
this pull request
Jul 24, 2020
Currently the code keeps tracks of the split startUids and updates them as the posting lists are split or empty parts are removed. Instead, update the list of startUids at the end of each step based on the contents of the map of startUids to posting list. This removes the need of keeping track of the same piece of information in two different ways. Also, fix a bug where the empty parts were removed from the list of splits but not from the map. This caused empty posting lists to be written to disk although it didn't affect normal execution because those parts were not accessible from the main posting list. (cherry picked from commit c51d007)
parasssh
pushed a commit
that referenced
this pull request
Aug 28, 2020
Currently the code keeps tracks of the split startUids and updates them as the posting lists are split or empty parts are removed. Instead, update the list of startUids at the end of each step based on the contents of the map of startUids to posting list. This removes the need of keeping track of the same piece of information in two different ways. Also, fix a bug where the empty parts were removed from the list of splits but not from the map. This caused empty posting lists to be written to disk although it didn't affect normal execution because those parts were not accessible from the main posting list. (cherry picked from commit c51d007)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the code keeps tracks of the split startUids and updates them
as the posting lists are split or empty parts are removed. Instead,
update the list of startUids at the end of each step based on the
contents of the map of startUids to posting list. This removes the need
of keeping track of the same piece of information in two different ways.
Also, fix a bug where the empty parts were removed from the list of
splits but not from the map. This caused empty posting lists to be
written to disk although it didn't affect normal execution because those
parts were not accessible from the main posting list.
This change is
Docs Preview: