Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings reported by ineffassign. #3147

Merged
merged 1 commit into from
Mar 21, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ee/acl/acl_curl_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ func TestCurlAuthorization(t *testing.T) {
failMsg: "Token is expired",
})
// login again using the refreshJwt
accessJwt, refreshJwt, err = z.HttpLogin(&z.LoginParams{
_, refreshJwt, err = z.HttpLogin(&z.LoginParams{
Endpoint: loginEndpoint,
RefreshJwt: refreshJwt,
})
Expand All @@ -109,7 +109,7 @@ func TestCurlAuthorization(t *testing.T) {
failMsg: "Token is expired",
})
// refresh the jwts again
accessJwt, refreshJwt, err = z.HttpLogin(&z.LoginParams{
_, refreshJwt, err = z.HttpLogin(&z.LoginParams{
Endpoint: loginEndpoint,
RefreshJwt: refreshJwt,
})
Expand All @@ -133,7 +133,7 @@ func TestCurlAuthorization(t *testing.T) {
glog.Infof("Sleeping for 35 seconds for acl caches to be refreshed")
time.Sleep(35 * time.Second)
// refresh the jwts again
accessJwt, refreshJwt, err = z.HttpLogin(&z.LoginParams{
_, _, err = z.HttpLogin(&z.LoginParams{
Endpoint: loginEndpoint,
RefreshJwt: refreshJwt,
})
Expand Down
2 changes: 2 additions & 0 deletions systest/21million/run_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ import (
"github.com/dgraph-io/dgraph/chunker"
"github.com/dgraph-io/dgraph/x"
"github.com/dgraph-io/dgraph/z"
"github.com/stretchr/testify/require"
)

func TestQueries(t *testing.T) {
Expand All @@ -53,6 +54,7 @@ func TestQueries(t *testing.T) {
// The test query and expected result are separated by a delimiter.
bodies := strings.SplitN(contents, "\n---\n", 2)
resp, err := dg.NewTxn().Query(context.Background(), bodies[0])
require.NoError(err)

t.Logf("running %s", file.Name())
if len(resp.GetJson()) > 0 {
Expand Down