Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw error instead of asserting in query #2243

Closed
wants to merge 2 commits into from
Closed

Throw error instead of asserting in query #2243

wants to merge 2 commits into from

Conversation

pawanrawal
Copy link
Contributor

@pawanrawal pawanrawal commented Mar 20, 2018 •
edited by manishrjain
Loading

Fixes #2227.

It's a simple change but opening a PR to mention the two cases where I think this could happen.

  1. It can happen during predicate move where when the request is received by a server it is no longer serving the predicate.
  2. It can also happen when we Remove a tablet if there isn't any data for it.

Essentially, whenever a tablet changes groups, this temporary error can happen. When we have debug logs, we could log this.

This change is Reviewable

@janardhan1993
Copy link
Contributor

:lgtm:

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

@pawanrawal
Copy link
Contributor Author

Merged to master with dec6a3b.

@pawanrawal pawanrawal closed this Mar 20, 2018
@pawanrawal pawanrawal deleted the pawan/query-temp-error branch March 21, 2018 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@janardhan1993 janardhan1993

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pawanrawal @janardhan1993