Prevent unnecessary safecopy in iterator parseKV #971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous implementation of parseKV would copy over the value slice every time, which is not necessary. The value slice should be copied only when we return the result of point lookups. The proposed patch remove safecopy call from the iterator.
jarifibrahim
requested review from
ashish-goswami and
manishrjain
as code owners
![pullrequest[bot]](https://avatars.githubusercontent.com/in/3434?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ A review job has been created and sent to the PullRequest network.
@jarifibrahim you can click here to see the review status or cancel the code review job.
manishrjain
approved these changes
Aug 7, 2019
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @ashish-goswami)
|
@ashish-goswami Review, please. |
ashish-goswami
approved these changes
Aug 9, 2019
|
Just check why travis is failing. |
|
The build on mac OS is failing on travis. It is failing for all PRs. |
jarifibrahim
pushed a commit
that referenced
this pull request
Mar 12, 2020
The previous implementation of parseKV would copy over the value slice every time we iterate, which is not necessary. The value slice should be copied only when we return the result of point lookups. The proposed patch removes safeCopy call from the iterator. (cherry picked from commit 74ed6da)
jarifibrahim
pushed a commit
that referenced
this pull request
Mar 13, 2020
This reverts commit 4a22cac. This branch does not contain the other block iterator changes. This patch causes segmentation fault.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation of parseKV would copy over the value slice
every time, which is not necessary. The value slice should be copied only
when we return the result of point lookups. The proposed patch remove
safecopy call from the iterator.
This change is