(release/v1.6) Confirm badgerMove entry required before rewrite (#1302)
#1502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Value log badgerMove entries for deleted keys are always rewritten. This leads to exponential DB size growth in heavy write/delete use cases with value pointer entries. To prevent this, a check has been added to confirm the value is still needed for badgerMove entries. (cherry picked from commit 3e1cdd9)
NamanJain8
requested review from
ashish-goswami,
jarifibrahim and
manishrjain
as code owners
|
Build failed because of |
jarifibrahim
approved these changes
Sep 9, 2020
There was a problem hiding this comment.
Reviewable status: 0 of 2 files reviewed, all discussions resolved (waiting on @ashish-goswami, @jarifibrahim, and @manishrjain)
mYmNeo
pushed a commit
to mYmNeo/badger
that referenced
this pull request
Jan 16, 2023
…permodeinc#1302) (hypermodeinc#1502) * Confirm `badgerMove` entry required before rewrite (hypermodeinc#1302) Value log badgerMove entries for deleted keys are always rewritten. This leads to exponential DB size growth in heavy write/delete use cases with value pointer entries. To prevent this, a check has been added to confirm the value is still needed for badgerMove entries. (cherry picked from commit 3e1cdd9) * remove KeepL0InMemory in db_test Co-authored-by: Julian Hegler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Value log badgerMove entries for deleted keys are always rewritten.
This leads to exponential DB size growth in heavy write/delete use
cases with value pointer entries. To prevent this, a check has been
added to confirm the value is still needed for badgerMove entries.
(cherry picked from commit 3e1cdd9)
This required fixing the build
This change is