Fix ValueThreshold for in-memory mode #1235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit increases the ValueThreshold for in-memory mode. The existing threshold was of 1 MB which means badger would crash if len(value) was greater than 1 MB. This commit sets the value threshold to MaxInt32 (around 2 GB). Badger transaction would return error if badger is running in in-memory mode and length of value is greater than the value threshold.
jarifibrahim
requested review from
ashish-goswami and
manishrjain
as code owners
poonai
approved these changes
Mar 2, 2020
manishrjain
approved these changes
Mar 2, 2020
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @ashish-goswami)
jarifibrahim
pushed a commit
that referenced
this pull request
Mar 24, 2020
This commit increases the ValueThreshold for in-memory mode. The existing threshold was of 1 MB which means badger would crash if len(value) was greater than 1 MB. This commit sets the value threshold to MaxInt32 (around 2 GB). Badger transaction would return an error if badger is running in in-memory mode and length of value is greater than the value threshold. Fixes #1234 (cherry picked from commit 5b4c0a6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit increases the ValueThreshold for in-memory mode. The
existing threshold was of 1 MB which means badger would crash if
len(value) was greater than 1 MB. This commit sets the value threshold
to MaxInt32 (around 2 GB). Badger transactions would return an error if
badger is running in in-memory mode and length of the value is greater than
the value threshold.
Fixes #1234
This change is