Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Value Checksum success test #1147

Merged
merged 4 commits into from
Dec 6, 2019
Merged

Add Value Checksum success test #1147

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b9bd4b7
Fix VerifyValueChecksum checks
tuesmiddt Nov 27, 2019
5be565a
Add test
Dec 6, 2019
5b78cf5
Merge branch 'master' into ibrahim/valuechecksum-test
Dec 6, 2019
8318a16
Refactor code
Dec 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
101 changes: 65 additions & 36 deletions value_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1137,7 +1137,7 @@ func TestBlockedDiscardStats(t *testing.T) {
func TestBlockedDiscardStatsOnClose(t *testing.T) {
dir, err := ioutil.TempDir("", "badger-test")
require.NoError(t, err)
defer os.Remove(dir)
defer removeDir(dir)

db, err := Open(getTestOptions(dir))
require.NoError(t, err)
Expand All @@ -1148,47 +1148,76 @@ func TestBlockedDiscardStatsOnClose(t *testing.T) {
require.NoError(t, db.Close())
}

// Regression test for https://github.com/dgraph-io/badger/issues/1049
func TestValueEntryCorruption(t *testing.T) {
dir, err := ioutil.TempDir("", "badger-test")
require.NoError(t, err)
defer removeDir(dir)

opt := getTestOptions(dir)
opt.VerifyValueChecksum = true
db, err := Open(opt)
require.NoError(t, err)

func TestValueEntryChecksum(t *testing.T) {
k := []byte("KEY")
v := []byte(fmt.Sprintf("val%100d", 10))
require.Greater(t, len(v), db.opt.ValueThreshold)
txnSet(t, db, k, v, 0)
t.Run("ok", func(t *testing.T) {
dir, err := ioutil.TempDir("", "badger-test")
require.NoError(t, err)
defer removeDir(dir)

path := db.vlog.fpath(0)
require.NoError(t, db.Close())
opt := getTestOptions(dir)
opt.VerifyValueChecksum = true
db, err := Open(opt)
require.NoError(t, err)

file, err := os.OpenFile(path, os.O_RDWR, 0644)
require.NoError(t, err)
offset := 50
orig := make([]byte, 1)
_, err = file.ReadAt(orig, int64(offset))
require.NoError(t, err)
// Corrupt a single bit.
_, err = file.WriteAt([]byte{7}, int64(offset))
require.NoError(t, err)
require.NoError(t, file.Close())
require.Greater(t, len(v), db.opt.ValueThreshold)
txnSet(t, db, k, v, 0)
require.NoError(t, db.Close())

db, err = Open(opt)
require.NoError(t, err)
db, err = Open(opt)
require.NoError(t, err)

txn := db.NewTransaction(false)
entry, err := txn.Get(k)
require.NoError(t, err)
txn := db.NewTransaction(false)
entry, err := txn.Get(k)
require.NoError(t, err)

x, err := entry.ValueCopy(nil)
require.Error(t, err)
require.Contains(t, err.Error(), "checksum mismatch")
require.Nil(t, x)
x, err := entry.ValueCopy(nil)
require.NoError(t, err)
require.Equal(t, v, x)

require.NoError(t, db.Close())
require.NoError(t, db.Close())
})
// Regression test for https://github.com/dgraph-io/badger/issues/1049
t.Run("Corruption", func(t *testing.T) {
dir, err := ioutil.TempDir("", "badger-test")
require.NoError(t, err)
defer removeDir(dir)

opt := getTestOptions(dir)
opt.VerifyValueChecksum = true
db, err := Open(opt)
require.NoError(t, err)

require.Greater(t, len(v), db.opt.ValueThreshold)
txnSet(t, db, k, v, 0)

path := db.vlog.fpath(0)
require.NoError(t, db.Close())

file, err := os.OpenFile(path, os.O_RDWR, 0644)
require.NoError(t, err)
offset := 50
orig := make([]byte, 1)
_, err = file.ReadAt(orig, int64(offset))
require.NoError(t, err)
// Corrupt a single bit.
_, err = file.WriteAt([]byte{7}, int64(offset))
require.NoError(t, err)
require.NoError(t, file.Close())

db, err = Open(opt)
require.NoError(t, err)

txn := db.NewTransaction(false)
entry, err := txn.Get(k)
require.NoError(t, err)

x, err := entry.ValueCopy(nil)
require.Error(t, err)
require.Contains(t, err.Error(), "checksum mismatch")
require.Nil(t, x)

require.NoError(t, db.Close())
})
}