Fix ineffassign warnings. #1055
Conversation
martinmr
requested review from
ashish-goswami,
jarifibrahim,
manishrjain and
a team
as code owners
![pullrequest[bot]](https://avatars.githubusercontent.com/in/3434?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ A review job has been created and sent to the PullRequest network.
@martinmr you can click here to see the review status or cancel the code review job.
There was a problem hiding this comment.
| 1 Message | |
|---|---|
| ✅ |
|
There was a problem hiding this comment.
The change itself looks good to me but it seems like it broke coverage somehow. Would be good to check coverall status and add any tests if required.
Reviewed with ❤️ by PullRequest
There was a problem hiding this comment.
Reviewable status: 0 of 3 files reviewed, all discussions resolved (waiting on @ashish-goswami, @jarifibrahim, and @manishrjain)
|
@martinmr Do you have a plugin that highlights these errors? |
There was a problem hiding this comment.
Found them here: https://deepsource.io/gh/jaipradeesh/badger/issues/
The author of this tool said he could send a PR to enable this in every change.
Reviewable status: 0 of 3 files reviewed, all discussions resolved (waiting on @ashish-goswami and @manishrjain)
(cherry picked from commit 50ddf21)
This change is