Bypass DirLockGaurd in Options #1046
Conversation
Pull from origin master
ehsannm
requested review from
ashish-goswami,
jarifibrahim,
manishrjain and
a team
as code owners
![pullrequest[bot]](https://avatars.githubusercontent.com/in/3434?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ A review job has been created and sent to the PullRequest network.
@ehsannm you can click here to see the review status or cancel the code review job.
|
|
| @@ -68,6 +68,8 @@ type Options struct { | |||
| CompactL0OnClose bool | |||
| LogRotatesToFlush int32 | |||
|
|
|||
| BypassLockGuard bool | |||
There was a problem hiding this comment.
Maybe use the terminology skip. It's more common place in code to expect that activating a flag like this will cause it to skip over a block of code/checks.
There was a problem hiding this comment.
Due to inactivity, PullRequest has cancelled this review job. You can reactivate the code review job from the PullRequest dashboard
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
stale
bot
added
the
status/stale
|
This issue was marked as stale and no activity has occurred since then, therefore it will now be closed. Please, reopen if the issue is still relevant. |
|
Is this completely defunct, because it would be really. really useful for me? |
jarifibrahim
removed
the
status/stale
|
@jonknight73 I've raised #1243 for this issue. |
Fixes #988 Based on #1046 This PR adds `BypassDirLock` option which allows badger to work without acquiring a lock on the data directory. This option could lead to data corruption if used with multiple badger instances trying to write to the same badger directory. Co-authored-by: Ehsan Noureddin Moosa <[email protected]>
Fixes #988 Based on #1046 This PR adds `BypassDirLock` option which allows badger to work without acquiring a lock on the data directory. This option could lead to data corruption if used with multiple badger instances trying to write to the same badger directory. Co-authored-by: Ehsan Noureddin Moosa <[email protected]> (cherry picked from commit 1bcbefc)
Fixes #988 Based on #1046 This PR adds `BypassDirLock` option which allows badger to work without acquiring a lock on the data directory. This option could lead to data corruption if used with multiple badger instances trying to write to the same badger directory. Co-authored-by: Ehsan Noureddin Moosa <[email protected]> (cherry picked from commit 1bcbefc)
Fixes hypermodeinc/badger#988 Based on hypermodeinc/badger#1046 This PR adds `BypassDirLock` option which allows badger to work without acquiring a lock on the data directory. This option could lead to data corruption if used with multiple badger instances trying to write to the same badger directory. Co-authored-by: Ehsan Noureddin Moosa <[email protected]>
This change is