Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace eventlog with normal logs #1193

Closed
jarifibrahim opened this issue Jan 14, 2020 · 4 comments
Closed

Replace eventlog with normal logs #1193

jarifibrahim opened this issue Jan 14, 2020 · 4 comments
Labels
exp/beginner Something most people could solve. good first issue These are simple issues that can be picked up by new contributors kind/maintenance Maintenance tasks, such as refactoring, with no impact in features. status/stale The issue hasn't had activity for a while and it's marked for closing.

Comments

@jarifibrahim
Copy link
Contributor

Badger uses eventLog to keep track of long-running background operations.
https://github.com/dgraph-io/badger/blob/2a90c665f1e57fdc48256f222ed5d826c554043c/levels.go#L38-L42

https://github.com/dgraph-io/badger/blob/2a90c665f1e57fdc48256f222ed5d826c554043c/value.go#L828-L832

These eventLogs are expensive as seen in #938 (comment)

All the trace/eventlog calls should be replaced with logger.Debugf(...) statements.
@jarifibrahim jarifibrahim added kind/maintenance Maintenance tasks, such as refactoring, with no impact in features. exp/beginner Something most people could solve. good first issue These are simple issues that can be picked up by new contributors labels Jan 14, 2020
@gabru-md
Copy link
Contributor

Hi @jarifibrahim
I've started writing Go quite recently. Can I work on it?

@jarifibrahim
Copy link
Contributor Author

Hey @gabru-md, feel free to work on it. We use https://godoc.org/golang.org/x/net/trace#EventLog which we don't really need. The task here to is to replace all the eventlog.Printf with logger.Debugf(..) statements.

@gabru-md gabru-md mentioned this issue Jan 21, 2020
Merged
@stale
Copy link

stale bot commented Feb 19, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the status/stale The issue hasn't had activity for a while and it's marked for closing. label Feb 19, 2020
@stale
Copy link

stale bot commented Feb 26, 2020

This issue was marked as stale and no activity has occurred since then, therefore it will now be closed. Please, reopen if the issue is still relevant.

@stale stale bot closed this as completed Feb 26, 2020
jarifibrahim pushed a commit that referenced this issue Apr 13, 2020
@gabru-md
Replace EventLog with Logger (#1203)
09dd2e1 
Fixes #1193
manishrjain pushed a commit to outcaste-io/outserv that referenced this issue Jul 6, 2022
@gabru-md
Replace EventLog with Logger (#1203)
ecfae99 
Fixes hypermodeinc/badger#1193
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
exp/beginner Something most people could solve. good first issue These are simple issues that can be picked up by new contributors kind/maintenance Maintenance tasks, such as refactoring, with no impact in features. status/stale The issue hasn't had activity for a while and it's marked for closing.
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jarifibrahim @gabru-md