-
Notifications
You must be signed in to change notification settings - Fork 658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VSCode Devcontainer #1718
VSCode Devcontainer #1718
Conversation
Signed-off-by: Philipp Schlarb <[email protected]>
Can one of the admins verify this patch? |
python3-pip \ | ||
python3-nacl \ | ||
# rocksdb python wrapper | ||
rocksdb=5.8.8 \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we use the latest version of rocksdb? v6.25.3?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found the comment from line 28, the issue with plenum. Thanks. I understand the reason for version 5.8.8 now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small recommended change. Other than that I'm thinking we should have the pytest settings pre-configured so the development environment is more complete from the start. Thoughts?
@WadeBarnes Do you mean providing the workspace settings.json for VScode ? |
Co-authored-by: Wade Barnes <[email protected]> Signed-off-by: Philipp Schlarb <[email protected]>
bc3ec03
to
50d50be
Compare
Yes, I was thinking some minimum settings for the tests, at least to start. It shouldn't be an issue since they would be meant to run in the dev container which is where we get the consistency for the development environment. |
Hm I think we would have to create a |
Signed-off-by: Philipp Schlarb <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small recommendation.
I'm also looking into some issues running the tests in the container. Some tests "appear" to fail with a "Test result not found" error, when in fact they either pass or are skipped as expected. You can see the true summary in the Output - Python Test Log console. The issue appears to be a bug in the https://github.com/microsoft/vscode-python extension. There have already been some fixes for related issues.
// "forwardPorts": [], | ||
|
||
// Use 'postCreateCommand' to run commands after the container is created. | ||
"postCreateCommand": "pip install .[tests]", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"postCreateCommand": "pip install .[tests]", | |
"postCreateCommand": "pip install flake8==3.8.4 .[tests]", |
Install flake8
otherwise there are Python (Output - Python) errors reported indicating flake8
is not installed.
I've confirmed (through the Output - Python Test Log console) all of the tests pass or are skipped as expected. Some of the The tests affected by the "Test result not found" issue are marked with a red circle with a red dot in the middle rather than a red circle with a red The "Test result not found" issue does not affect the ability to run the tests in debug mode and set breakpoints to step through the code. |
The issues with the tests have been marked as a known issue here; #1729 |
Request for documentation has been added as a separate issue here; #1728 |
Addition of VSCode Devcontainer files.
Signed-off-by: Philipp Schlarb [email protected]