Add support for publishing Debian packages #1680
Conversation
|
(ci) test this please |
6 similar comments
|
(ci) test this please |
|
(ci) test this please |
|
(ci) test this please |
|
(ci) test this please |
|
(ci) test this please |
|
(ci) test this please |
WadeBarnes
force-pushed
the
publishing-artifacts
branch
from
dd8da4d to
3888811
Compare
There was a problem hiding this comment.
Thanks @WadeBarnes for this PR.
In general, it looks good to me. There are just adjustments left and maybe the base image of node-lint has to be changed.
| run: | | ||
| DOCKER_IMAGE=ghcr.io/${{ env.GITHUB_REPOSITORY_NAME }}/node-lint | ||
| # ToDo - Update hard coded 'ubuntu-18-04' tag when integrating these flows with the ubuntu-20.04-upgrade branch. | ||
| TAGS="${DOCKER_IMAGE}:latest,${DOCKER_IMAGE}:ubuntu-18-04" |
There was a problem hiding this comment.
Is there a reason why we base the node-lint image on ubuntu:18.04 instead of ubuntu:16.04?
I know that it's the same for indy-plenum. Just wondering why
There was a problem hiding this comment.
The OS version for the lint image is less important than the version of the tools installed for linting. It looks like it was a matter of choice when the dockerfile was originally created.
| @@ -1,6 +1,6 @@ | |||
| # Development | |||
| FROM ubuntu:18.04 | |||
There was a problem hiding this comment.
Since it works with 18.04 I'm inclined to leave it. The OS version for the lint image is less important than the version of the tools installed for linting.
|
(ci) test this please |
WadeBarnes
force-pushed
the
publishing-artifacts
branch
from
0cddc67 to
f6f72f1
Compare
|
(ci) test this please |
WadeBarnes
force-pushed
the
publishing-artifacts
branch
2 times, most recently
from
1b82b9b to
36f3089
Compare
- Following the pattern and enhancements developed for the plenum workflows. - Update Sovrin signing keys. - Update test runner (`runner.py`) to automatically report the test results for each set of tests. - Enhancements from hyperledger/indy-plenum@06d9406 - Add an option for suppressing the automated junitxml results. - Add `--nojunitxml` flag to allow junitxml results to be suppressed. - Suppress junitxml output when running the Jenkins Pipelines - Generation of junitxml output for the `indy_node/test/auth_rule` tests causes the tests to crash and fail when run via Jenkins. - The GHA workflows use the junitxml results for reporting, and are not affected by the same issue seen with Jenkins. - Address feedback from @udosson Signed-off-by: Wade Barnes <[email protected]>
WadeBarnes
force-pushed
the
publishing-artifacts
branch
from
36f3089 to
0730c69
Compare
|
(ci) test this please |
|
@udosson, ready for another review. I've also resolved the issues with the Jenkins pipelines. It was the added |
| @@ -1,6 +1,6 @@ | |||
| # Development | |||
| FROM ubuntu:18.04 | |||
| run: | | ||
| DOCKER_IMAGE=ghcr.io/${{ env.GITHUB_REPOSITORY_NAME }}/node-lint | ||
| # ToDo - Update hard coded 'ubuntu-18-04' tag when integrating these flows with the ubuntu-20.04-upgrade branch. | ||
| TAGS="${DOCKER_IMAGE}:latest,${DOCKER_IMAGE}:ubuntu-18-04" |
runner.py) to automatically report the test results for each set of tests.Signed-off-by: Wade Barnes [email protected]