Add script for remove ledger #1650
Conversation
Signed-off-by: anton.denishchenko <[email protected]>
adenishchenko
requested review from
lampkin-diet,
ashcherbakov,
skhoroshavin and
Toktar
as code owners
|
Can one of the admins verify this patch? |
Signed-off-by: anton.denishchenko <[email protected]>
Signed-off-by: anton.denishchenko <[email protected]>
|
(ci) test this please |
There was a problem hiding this comment.
I'd highly recommend the script provide some feedback to the user and wait for confirmation.
It should clearly indicate it's about to delete a ledger, which ledger it's about to delete, describe the consequences, and then wait for confirmation from the user.
Some help text for the script would also be useful for those that are curious about what the script does, but don't want to read and fully understand the code.
|
@WadeBarnes Great ideas |
Signed-off-by: anton.denishchenko <[email protected]>
Signed-off-by: anton.denishchenko <[email protected]>
adenishchenko
force-pushed
the
migration_mainnet
branch
from
eb429c5 to
dfe641b
Compare
Signed-off-by: anton.denishchenko <[email protected]>
|
(ic) test this please. |
There was a problem hiding this comment.
Code is failing static analysis; https://build.sovrin.org/job/indy-node/job/indy-node-verify-x86_64/2836/execution/node/18/log/
Signed-off-by: anton.denishchenko <[email protected]>
|
(ci) test this please |
|
(ci) ok to test |
|
@WadeBarnes It seems that all comments were processed. Could you review this again, please? |
|
@Toktar, @skhoroshavin, We just need approval from a code owner. |
Add script for remove ledger Signed-off-by: toktar <[email protected]> Sign-off-executed-by: toktar <[email protected]> Approved-at: behalf
Add script for remove ledger Signed-off-by: toktar <[email protected]> Sign-off-executed-by: toktar <[email protected]> Approved-at: behalf Signed-off-by: toktar <[email protected]> Sign-off-executed-by: toktar <[email protected]> Approved-at: master-stable Signed-off-by: toktar <[email protected]> Sign-off-executed-by: toktar <[email protected]> Approved-at: master-stable Signed-off-by: toktar <[email protected]> Sign-off-executed-by: toktar <[email protected]> Approved-at: master-stable Signed-off-by: toktar <[email protected]> Sign-off-executed-by: toktar <[email protected]> Approved-at: master-stable Signed-off-by: toktar <[email protected]> Sign-off-executed-by: toktar <[email protected]> Approved-at: master-stable Signed-off-by: toktar <[email protected]> Sign-off-executed-by: toktar <[email protected]> Approved-at: master-stable Signed-off-by: toktar <[email protected]> Sign-off-executed-by: toktar <[email protected]> Approved-at: master-stable Signed-off-by: toktar <[email protected]> Sign-off-executed-by: toktar <[email protected]> Approved-at: master-stable
Signed-off-by: anton.denishchenko [email protected]