-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: key's id name according to the DID Peer new specs #126 #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elribonazo
approved these changes
Jan 4, 2024
mineme0110
approved these changes
Feb 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM , I have tested locally with mediator and achieved mediation
FabioPinheiro
force-pushed
the
fix/126-fix-did-peer-key-id
branch
from
February 6, 2024 12:00
18a24df
to
9180121
Compare
atala-dev
added a commit
that referenced
this pull request
Feb 28, 2024
# [5.0.0](v4.0.0...v5.0.0) (2024-02-28) ### Bug Fixes * add reference app + mediator live mode ([#177](#177)) ([6ebf48a](6ebf48a)) * e2e tests improvement ([#178](#178)) ([eb6a5ab](eb6a5ab)) * key's id name according to the DID Peer new specs [#126](#126) ([#148](#148)) ([a851b69](a851b69)) * Manually generating the missing changelog and breaking changes b… ([#167](#167)) ([24ecc04](24ecc04)) * Recover JTI field correctly. Allowing to regenerate the original JWT string ([#171](#171)) ([913f3fa](913f3fa)) * feat!: Implementing Pluto Repositories (#160) ([ce7669f](ce7669f)), closes [#160](#160) ### BREAKING CHANGES * - Domain.Credential now has uuid (string) as an optional attribute in the class - Change StorePrismDID Function parameters, removing keyPathIndex and privateKeyMetadataId which were not in use - Small change in the getCredentialMetadata and getLinkSecret to return null when not found - Change Pluto interface to use CredentialMetadata class VS what it was using before. - Change Pluto interface, storeMediator now accepts a Mediator class and not 3 attributes, mediator, host and routing - Rename storePrivateKeys to storePrivateKey - Change Pluto interface, using Domain.PrismDID instead of Domain.PrismDID which is being removed - Added new properties to handle Anoncreds credentials properties. - Re-implemented Pluto which is now available again to all the users. import SDK from "@atala/prism-wallet-sdk"; import IndexDB from "@pluto-encrypted/indexdb"; const store = new SDK.Store({ name: "test", storage: IndexDB, password: Buffer.from("demoapp").toString("hex") }); const pluto = new SDK.Pluto(store, apollo); Migrations, schemas, queries and error handling have been moved to the SDK again but user's which were using the existing storages can just pass the indexDB pluto-encrypted storage and it will integrate with the new db schemas, migrations, etc
elribonazo
pushed a commit
that referenced
this pull request
May 2, 2024
# [5.0.0](v4.0.0...v5.0.0) (2024-02-28) ### Bug Fixes * add reference app + mediator live mode ([#177](#177)) ([6ebf48a](6ebf48a)) * e2e tests improvement ([#178](#178)) ([eb6a5ab](eb6a5ab)) * key's id name according to the DID Peer new specs [#126](#126) ([#148](#148)) ([a851b69](a851b69)) * Manually generating the missing changelog and breaking changes b… ([#167](#167)) ([24ecc04](24ecc04)) * Recover JTI field correctly. Allowing to regenerate the original JWT string ([#171](#171)) ([913f3fa](913f3fa)) * feat!: Implementing Pluto Repositories (#160) ([ce7669f](ce7669f)), closes [#160](#160) ### BREAKING CHANGES * - Domain.Credential now has uuid (string) as an optional attribute in the class - Change StorePrismDID Function parameters, removing keyPathIndex and privateKeyMetadataId which were not in use - Small change in the getCredentialMetadata and getLinkSecret to return null when not found - Change Pluto interface to use CredentialMetadata class VS what it was using before. - Change Pluto interface, storeMediator now accepts a Mediator class and not 3 attributes, mediator, host and routing - Rename storePrivateKeys to storePrivateKey - Change Pluto interface, using Domain.PrismDID instead of Domain.PrismDID which is being removed - Added new properties to handle Anoncreds credentials properties. - Re-implemented Pluto which is now available again to all the users. import SDK from "@atala/prism-wallet-sdk"; import IndexDB from "@pluto-encrypted/indexdb"; const store = new SDK.Store({ name: "test", storage: IndexDB, password: Buffer.from("demoapp").toString("hex") }); const pluto = new SDK.Pluto(store, apollo); Migrations, schemas, queries and error handling have been moved to the SDK again but user's which were using the existing storages can just pass the indexDB pluto-encrypted storage and it will integrate with the new db schemas, migrations, etc
elribonazo
added a commit
that referenced
this pull request
May 2, 2024
Fix for #126 Signed-off-by: Francisco Javier Ribó Labrador <[email protected]> Signed-off-by: Francisco Javier Ribo Labrador <[email protected]>
elribonazo
pushed a commit
that referenced
this pull request
May 2, 2024
# [5.0.0](v4.0.0...v5.0.0) (2024-02-28) ### Bug Fixes * add reference app + mediator live mode ([#177](#177)) ([6ebf48a](6ebf48a)) * e2e tests improvement ([#178](#178)) ([eb6a5ab](eb6a5ab)) * key's id name according to the DID Peer new specs [#126](#126) ([#148](#148)) ([a851b69](a851b69)) * Manually generating the missing changelog and breaking changes b… ([#167](#167)) ([24ecc04](24ecc04)) * Recover JTI field correctly. Allowing to regenerate the original JWT string ([#171](#171)) ([913f3fa](913f3fa)) * feat!: Implementing Pluto Repositories (#160) ([ce7669f](ce7669f)), closes [#160](#160) ### BREAKING CHANGES * - Domain.Credential now has uuid (string) as an optional attribute in the class - Change StorePrismDID Function parameters, removing keyPathIndex and privateKeyMetadataId which were not in use - Small change in the getCredentialMetadata and getLinkSecret to return null when not found - Change Pluto interface to use CredentialMetadata class VS what it was using before. - Change Pluto interface, storeMediator now accepts a Mediator class and not 3 attributes, mediator, host and routing - Rename storePrivateKeys to storePrivateKey - Change Pluto interface, using Domain.PrismDID instead of Domain.PrismDID which is being removed - Added new properties to handle Anoncreds credentials properties. - Re-implemented Pluto which is now available again to all the users. import SDK from "@atala/prism-wallet-sdk"; import IndexDB from "@pluto-encrypted/indexdb"; const store = new SDK.Store({ name: "test", storage: IndexDB, password: Buffer.from("demoapp").toString("hex") }); const pluto = new SDK.Pluto(store, apollo); Migrations, schemas, queries and error handling have been moved to the SDK again but user's which were using the existing storages can just pass the indexDB pluto-encrypted storage and it will integrate with the new db schemas, migrations, etc
elribonazo
pushed a commit
that referenced
this pull request
May 3, 2024
# [5.0.0](v4.0.0...v5.0.0) (2024-02-28) ### Bug Fixes * add reference app + mediator live mode ([#177](#177)) ([6ebf48a](6ebf48a)) * e2e tests improvement ([#178](#178)) ([eb6a5ab](eb6a5ab)) * key's id name according to the DID Peer new specs [#126](#126) ([#148](#148)) ([a851b69](a851b69)) * Manually generating the missing changelog and breaking changes b… ([#167](#167)) ([24ecc04](24ecc04)) * Recover JTI field correctly. Allowing to regenerate the original JWT string ([#171](#171)) ([913f3fa](913f3fa)) * feat!: Implementing Pluto Repositories (#160) ([ce7669f](ce7669f)), closes [#160](#160) ### BREAKING CHANGES * - Domain.Credential now has uuid (string) as an optional attribute in the class - Change StorePrismDID Function parameters, removing keyPathIndex and privateKeyMetadataId which were not in use - Small change in the getCredentialMetadata and getLinkSecret to return null when not found - Change Pluto interface to use CredentialMetadata class VS what it was using before. - Change Pluto interface, storeMediator now accepts a Mediator class and not 3 attributes, mediator, host and routing - Rename storePrivateKeys to storePrivateKey - Change Pluto interface, using Domain.PrismDID instead of Domain.PrismDID which is being removed - Added new properties to handle Anoncreds credentials properties. - Re-implemented Pluto which is now available again to all the users. import SDK from "@atala/prism-wallet-sdk"; import IndexDB from "@pluto-encrypted/indexdb"; const store = new SDK.Store({ name: "test", storage: IndexDB, password: Buffer.from("demoapp").toString("hex") }); const pluto = new SDK.Pluto(store, apollo); Migrations, schemas, queries and error handling have been moved to the SDK again but user's which were using the existing storages can just pass the indexDB pluto-encrypted storage and it will integrate with the new db schemas, migrations, etc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a BREAKING CHANGE
Jira link
Checklist