Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removing terser to allow an unminified build that is easier to d… #127

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

elribonazo
Copy link
Contributor

@elribonazo elribonazo commented Nov 17, 2023

Description

As part of technical debt we want to remove terser in order to avoid minifying the code which should be on the developer's side and choice and also so simplify debugging by removing mangling on function names and attributes.

Jira link

N/A

Checklist

  • Self-reviewed the diff
  • New code has inline documentation
  • New code has proper comments/tests
  • Any changes not covered by tests have been tested manually

@elribonazo
Copy link
Contributor Author

fixes #112

Copy link

Lines Statements Branches Functions
Coverage: 37%
36.75% (1636/4451) 25.8% (714/2767) 39% (495/1269)

JUnit

Tests Skipped Failures Errors Time
209 2 💤 0 ❌ 0 🔥 55.705s ⏱️

Copy link
Contributor

@amagyar-iohk amagyar-iohk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@elribonazo elribonazo merged commit d2f71cc into master Nov 17, 2023
@elribonazo elribonazo deleted the feature/remove-terser branch November 17, 2023 14:18
mixmix pushed a commit to mixmix/atala-prism-wallet-sdk-ts that referenced this pull request May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants