Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: extending Agent.acceptInvitation to handle OOB + Prism #111

Merged
merged 1 commit into from
Nov 10, 2023
Merged

feat: extending Agent.acceptInvitation to handle OOB + Prism #111

merged 1 commit into from
Nov 10, 2023

Conversation

curtis-h
Copy link
Contributor

@curtis-h curtis-h commented Nov 3, 2023 •
edited
Loading

Description

Extending acceptInvitation to handle both OOB and Prism invitations.
Marking acceptDIDCommInvitation as deprecated.
Updating Browser Demo to use acceptInvitation

Jira link

https://input-output.atlassian.net/browse/ATL-4064

Checklist

  • Self-reviewed the diff
  • New code has inline documentation
  • New code has proper comments/tests
  • Any changes not covered by tests have been tested manually

@curtis-h curtis-h self-assigned this Nov 3, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 3, 2023

Lines Statements Branches Functions
Coverage: 42%
 37.29% (1543/4137) 25% (717/2868) 38.46% (485/1261)

JUnit

Tests Skipped Failures Errors Time
202 0 💤 0 ❌ 0 🔥 1m 32s ⏱️

milosh86
milosh86 approved these changes Nov 3, 2023
View reviewed changes
Copy link
Contributor

@milosh86 milosh86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍 ... I'll open discussion on Monday about Onboard & Authenticate to make a decision if we are continue to maintain it or we deprecate/remove it.

@curtis-h curtis-h merged commit ce8326b into master Nov 10, 2023
@curtis-h curtis-h deleted the feature/ATL-4064 branch November 10, 2023 08:39
amagyar-iohk pushed a commit that referenced this pull request Nov 13, 2023
@semantic-release-bot
chore(release): release 3.1.0
26dc305 
# [3.1.0](v3.0.0...v3.1.0) (2023-11-13)

### Bug Fixes

* CI pipeline issues. ([#121](#121)) ([28b5a8f](28b5a8f))

### Features

* extending Agent.acceptInvitation to handle OOB + Prism ([#111](#111)) ([ce8326b](ce8326b))
github-actions bot pushed a commit that referenced this pull request Nov 13, 2023
@amagyar-iohk
feat(docs): (26dc305) chore(release): release 3.1.0
7ae1962 
# [3.1.0](v3.0.0...v3.1.0) (2023-11-13)

### Bug Fixes

* CI pipeline issues. ([#121](#121)) ([28b5a8f](28b5a8f))

### Features

* extending Agent.acceptInvitation to handle OOB + Prism ([#111](#111)) ([ce8326b](ce8326b))
amagyar-iohk added a commit that referenced this pull request Nov 13, 2023
@amagyar-iohk
chore(release): release 3.1.0
f268a50 
# [3.1.0](v3.0.0...v3.1.0) (2023-11-13)

### Bug Fixes

* CI pipeline issues. ([#121](#121)) ([28b5a8f](28b5a8f))

### Features

* extending Agent.acceptInvitation to handle OOB + Prism ([#111](#111)) ([ce8326b](ce8326b))
amagyar-iohk added a commit that referenced this pull request Nov 13, 2023
@amagyar-iohk
chore(release): release 3.1.0 (#124)
2a4a05f 
# [3.1.0](v3.0.0...v3.1.0) (2023-11-13)

### Bug Fixes

* CI pipeline issues. ([#121](#121)) ([28b5a8f](28b5a8f))

### Features

* extending Agent.acceptInvitation to handle OOB + Prism ([#111](#111)) ([ce8326b](ce8326b))
github-actions bot pushed a commit that referenced this pull request Nov 29, 2023
@amagyar-iohk
feat(docs): (2a4a05f) chore(release): release 3.1.0 (#124)
54cb617 
# [3.1.0](v3.0.0...v3.1.0) (2023-11-13)

### Bug Fixes

* CI pipeline issues. ([#121](#121)) ([28b5a8f](28b5a8f))

### Features

* extending Agent.acceptInvitation to handle OOB + Prism ([#111](#111)) ([ce8326b](ce8326b))
@lley154 lley154 mentioned this pull request Apr 12, 2024
Closed
mixmix pushed a commit to mixmix/atala-prism-wallet-sdk-ts that referenced this pull request May 6, 2024
@curtis-h @elribonazo
feat: extending Agent.acceptInvitation to handle OOB + Prism (hyperle…
31b02f0 
…dger#111)

Signed-off-by: Francisco Javier Ribó Labrador <[email protected]>
mixmix pushed a commit to mixmix/atala-prism-wallet-sdk-ts that referenced this pull request May 6, 2024
@amagyar-iohk @elribonazo
chore(release): release 3.1.0 (hyperledger#124)
c10d707 
# [3.1.0](v3.0.0...v3.1.0) (2023-11-13)

### Bug Fixes

* CI pipeline issues. ([hyperledger#121](hyperledger#121)) ([28b5a8f](28b5a8f))

### Features

* extending Agent.acceptInvitation to handle OOB + Prism ([hyperledger#111](hyperledger#111)) ([ce8326b](ce8326b))

Signed-off-by: Francisco Javier Ribó Labrador <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milosh86 milosh86 milosh86 approved these changes

@elribonazo elribonazo Awaiting requested review from elribonazo

Assignees

@curtis-h curtis-h

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@curtis-h @milosh86