Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pollux): add anoncreds issuance #96

Merged
merged 1 commit into from
Aug 28, 2023
Merged

Conversation

goncalo-frade-iohk
Copy link
Contributor

No description provided.

@goncalo-frade-iohk goncalo-frade-iohk force-pushed the feature/ATL-4785 branch 2 times, most recently from 80c9068 to 8882142 Compare August 27, 2023 19:22
@goncalo-frade-iohk goncalo-frade-iohk marked this pull request as ready for review August 27, 2023 19:22
@goncalo-frade-iohk goncalo-frade-iohk force-pushed the feature/ATL-4785 branch 3 times, most recently from 6279608 to eba4e5a Compare August 28, 2023 10:51
Copy link
Contributor

@hamada147 hamada147 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General note: some files contains headers and others don't
Inquiry: why did we change some naming like me keyAggrements to keyAggrement?
Other than that LGTM

@goncalo-frade-iohk
Copy link
Contributor Author

General note: some files contains headers and others don't
Inquiry: why did we change some naming like me keyAggrements to keyAggrement?
Other than that LGTM

@hamada147 first yup nice catch removed the headers ;)
On the keyAggrements it was not us it was didcomm-rust uniffi that changed ;)

@hamada147
Copy link
Contributor

General note: some files contains headers and others don't

Inquiry: why did we change some naming like me keyAggrements to keyAggrement?

Other than that LGTM

@hamada147 first yup nice catch removed the headers ;)

On the keyAggrements it was not us it was didcomm-rust uniffi that changed ;)

Oh, didn't know that. Anyway, awesome work mate 🤗

As didcomm swift repo has changed this also updates the breaking changes
@goncalo-frade-iohk goncalo-frade-iohk merged commit 0d474a9 into main Aug 28, 2023
@goncalo-frade-iohk goncalo-frade-iohk deleted the feature/ATL-4785 branch August 28, 2023 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants