Replace 1.4 by pure secp256k1 implementation #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This logic was based on BitcoinKit framework and was changed to our needs.
This logic was based on BitcoinKit framework and was changed to our needs.
…st use secp256k1.swift lib secp256k1 lib uses libsecp256k1 internally that is the same one used by Prism SDK1.4 internally
milosh86
approved these changes
Mar 8, 2023
hamada147
approved these changes
Mar 8, 2023
| @@ -0,0 +1,62 @@ | |||
| // | |||
| // File.swift | |||
There was a problem hiding this comment.
Suggested change
| // File.swift | |
| // ECVerify.swift |
There was a problem hiding this comment.
Uhh cannot forget actually to delete all this comment nice catch :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a great step since 1.4 added a few issues that are problematic to development.
Mainly it didn't allow for targets like: macOS, watchOS, tvOS.
Besides that it had issues running on arm64 Macs making any developer that intended to use the SDK to disregard arm64 iOS sim.
Now the target macOS was added and the SDK runs well in Xcode arm64 mode without the need to use Rosetta.
Tests were added to make sure the cryptographic logic is correct and checks were made before this change to acknowledge that the outputs from the new implementation were the same as the 1.4 outputs.