Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: swift package complains of having a dependency on a branch #182

Merged
merged 1 commit into from
Nov 27, 2024
Merged

fix: swift package complains of having a dependency on a branch #182

merged 1 commit into from
Nov 27, 2024

Conversation

goncalo-frade-iohk
Copy link
Contributor

@goncalo-frade-iohk goncalo-frade-iohk commented Nov 26, 2024 •
edited
Loading

Description:

There is a problem with this package right now since it depends of a branch. Swift package doesnt allow that for production.

#180

Checklist:

  • My PR follows the contribution guidelines of this project
  • My PR is free of third-party dependencies that don't comply with the Allowlist
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked the PR title to follow the conventional commit specification

@goncalo-frade-iohk goncalo-frade-iohk requested a review from a team as a code owner November 26, 2024 12:03
@mineme0110
Copy link

@goncalo-frade-iohk build is failing

@goncalo-frade-iohk
Copy link
Contributor Author

Merging since the build fail is due to the test report plugin not the build and tests that pass.

@goncalo-frade-iohk goncalo-frade-iohk enabled auto-merge (rebase) November 26, 2024 13:41
@goncalo-frade-iohk goncalo-frade-iohk force-pushed the fix/swift-build branch 5 times, most recently from c43d9ee to 42af416 Compare November 26, 2024 15:57
@goncalo-frade-iohk goncalo-frade-iohk merged commit a7efde5 into main Nov 27, 2024
4 checks passed
@goncalo-frade-iohk goncalo-frade-iohk deleted the fix/swift-build branch November 27, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mineme0110 mineme0110 mineme0110 approved these changes

@elribonazo elribonazo elribonazo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@goncalo-frade-iohk @mineme0110 @elribonazo