Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: provide abstraction for keychain component #102

Merged
merged 1 commit into from
Sep 27, 2023
Merged

feat: provide abstraction for keychain component #102

merged 1 commit into from
Sep 27, 2023

Conversation

goncalo-frade-iohk
Copy link
Contributor

@goncalo-frade-iohk goncalo-frade-iohk commented Sep 27, 2023 •
edited
Loading

Overview

Abstraction of keychain, it will make easy to mock on tests since while testing you cannot use keychain

Checklist

My PR contains...

  • No code changes (changes to documentation, CI, metadata, etc.)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes
  • are not breaking changes
  • If yes to the above: I have updated the documentation accordingly

Documentation

  • My changes do not require a change to the project documentation
  • My changes require a change to the project documentation
  • If yes to the above: I have updated the documentation accordingly

Tests

  • My changes can not or do not need to be tested
  • My changes can and should be tested by unit and/or integration tests
  • If yes to the above: I have added tests to cover my changes
  • If yes to the above: I have taken care to cover edge cases in my tests

@goncalo-frade-iohk goncalo-frade-iohk merged commit bf2e59f into main Sep 27, 2023
3 checks passed
@goncalo-frade-iohk goncalo-frade-iohk deleted the feature/add-keychain-abstraction branch September 27, 2023 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hamada147 hamada147 hamada147 approved these changes

@elribonazo elribonazo Awaiting requested review from elribonazo

@amagyar-iohk amagyar-iohk Awaiting requested review from amagyar-iohk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@goncalo-frade-iohk @hamada147