Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Upgrade dependencies & Code enhancements #98

Merged
merged 1 commit into from
Sep 9, 2023

Conversation

hamada147
Copy link
Contributor

@hamada147 hamada147 commented Sep 8, 2023

@hamada147 hamada147 added the enhancement New feature or request label Sep 8, 2023
@hamada147 hamada147 self-assigned this Sep 8, 2023
@atala-dev
Copy link
Contributor

atala-dev commented Sep 8, 2023

Code Coverage

File Coverage [34.81%]
atala-prism-sdk/src/androidMain/kotlin/io/iohk/atala/prism/walletsdk/pluto/data/DbConnection.kt 0.00%
atala-prism-sdk/src/commonMain/kotlin/io/iohk/atala/prism/walletsdk/apollo/ApolloImpl.kt 70.59%
atala-prism-sdk/src/commonMain/kotlin/io/iohk/atala/prism/walletsdk/castor/CastorImpl.kt 46.88%
atala-prism-sdk/src/commonMain/kotlin/io/iohk/atala/prism/walletsdk/castor/did/DIDUrlParser.kt 100.00%
atala-prism-sdk/src/commonMain/kotlin/io/iohk/atala/prism/walletsdk/castor/did/prismdid/LongFormPrismDID.kt 0.00%
atala-prism-sdk/src/commonMain/kotlin/io/iohk/atala/prism/walletsdk/castor/did/prismdid/PrismDIDPublicKey.kt 61.90%
atala-prism-sdk/src/commonMain/kotlin/io/iohk/atala/prism/walletsdk/castor/resolvers/LongFormPrismDIDResolver.kt 50.00%
atala-prism-sdk/src/commonMain/kotlin/io/iohk/atala/prism/walletsdk/castor/shared/CastorShared.kt 40.27%
atala-prism-sdk/src/commonMain/kotlin/io/iohk/atala/prism/walletsdk/mercury/MercuryImpl.kt 29.81%
atala-prism-sdk/src/commonMain/kotlin/io/iohk/atala/prism/walletsdk/mercury/forward/ForwardMessage.kt 0.00%
atala-prism-sdk/src/commonMain/kotlin/io/iohk/atala/prism/walletsdk/mercury/resolvers/DIDCommWrapper.kt 0.00%
atala-prism-sdk/src/commonMain/kotlin/io/iohk/atala/prism/walletsdk/mercury/resolvers/DefaultSecretsResolverImpl.kt 0.00%
atala-prism-sdk/src/commonMain/kotlin/io/iohk/atala/prism/walletsdk/pollux/PolluxImpl.kt 0.00%
atala-prism-sdk/src/commonMain/kotlin/io/iohk/atala/prism/walletsdk/prismagent/protocols/issueCredential/CredentialPreview.kt 80.00%
atala-prism-sdk/src/commonMain/kotlin/io/iohk/atala/prism/walletsdk/prismagent/protocols/issueCredential/IssueCredential.kt 66.67%
atala-prism-sdk/src/commonMain/kotlin/io/iohk/atala/prism/walletsdk/prismagent/protocols/mediation/MediationRequest.kt 0.00%
atala-prism-sdk/src/commonMain/kotlin/io/iohk/atala/prism/walletsdk/prismagent/shared/PrismShared.kt 0.00%
atala-prism-sdk/src/jvmMain/kotlin/io/iohk/atala/prism/walletsdk/pluto/data/DbConnection.kt 0.00%
Total Project Coverage 26.97%

@github-actions
Copy link

github-actions bot commented Sep 8, 2023

Unit Test Results

63 tests  ±0   62 ✔️ ±0   11s ⏱️ -2s
18 suites ±0     1 💤 ±0 
18 files   ±0     0 ±0 

Results for commit b3c4ff9. ± Comparison against base commit c23e0ac.

♻️ This comment has been updated with latest results.

README.md Outdated Show resolved Hide resolved
@antonbaliasnikov
Copy link

@amagyar-iohk , why we have e2e failures here? could you, please, check?

@hamada147
Copy link
Contributor Author

hamada147 commented Sep 9, 2023

The e2e was failing due to something that @amagyar-iohk already fixed, but we discovered that the SDK decoding caused a crash. All crash details are on this ticket ATL-5727, and a fix has been implemented and provided here.

@hamada147 hamada147 added the bug Something isn't working label Sep 9, 2023
@hamada147 hamada147 merged commit 3e44f3f into main Sep 9, 2023
5 checks passed
@hamada147 hamada147 deleted the update/dependencies branch September 9, 2023 00:11
hamada147 added a commit that referenced this pull request May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants