Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(agent): add mediation and ability to send messages #24

Merged
merged 1 commit into from
Feb 16, 2023

Conversation

goncalo-frade-iohk
Copy link
Contributor

Need to add tests but since it is already a quite large PR. I will initiate a draft PR.

@hamada147
Copy link
Contributor

hamada147 commented Feb 6, 2023

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ KOTLIN ktlint 90 7 0 194.42s
✅ REPOSITORY checkov yes no 14.54s
✅ REPOSITORY devskim yes no 0.97s
✅ REPOSITORY dustilock yes no 0.02s
✅ REPOSITORY git_diff yes no 0.02s
✅ REPOSITORY secretlint yes no 1.78s
✅ REPOSITORY syft yes no 0.69s
✅ REPOSITORY trivy yes no 4.08s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

import kotlinx.coroutines.flow.flow
import kotlinx.coroutines.flow.map

final class BasicMediationHandler(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we going to have multiple MediationHandler implementations? If not, why Basic instead of MediatorHandlerImpl?
Just curious, if I see Basic I would expect a Custom or Advanced or something more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It depends on @goncalo-frade-iohk answer.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah we can change the name. This is basically an implementation we provide but the developer can provide any implementation that he desires.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. In that case in my opinion would make more sense to name it DefaultMediationHandler, if a user wants to use its own implementation fine, if not we have our default implementation.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@cristianIOHK
Copy link
Contributor

@goncalo-frade-iohk @hamada147 @elribonazo left a bunch of comments, would like your opinion on those.

@goncalo-frade-iohk goncalo-frade-iohk force-pushed the feature/ATL-3064 branch 2 times, most recently from 352d230 to 504dc55 Compare February 8, 2023 14:06
@goncalo-frade-iohk goncalo-frade-iohk marked this pull request as ready for review February 8, 2023 14:26
@goncalo-frade-iohk goncalo-frade-iohk force-pushed the feature/ATL-3064 branch 4 times, most recently from 42d5ffd to 9b0e8e1 Compare February 15, 2023 10:41
@goncalo-frade-iohk goncalo-frade-iohk force-pushed the feature/ATL-3064 branch 2 times, most recently from 6eb95d2 to ee9a9ba Compare February 16, 2023 11:47
@goncalo-frade-iohk goncalo-frade-iohk merged commit 2536085 into main Feb 16, 2023
@goncalo-frade-iohk goncalo-frade-iohk deleted the feature/ATL-3064 branch February 16, 2023 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants