-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(agent): add mediation and ability to send messages #24
Conversation
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports |
e1944ac
to
9a44ecf
Compare
prism-agent/src/commonMain/kotlin/io/iohk/atala/prism/walletsdk/prismagent/ConnectionManager.kt
Outdated
Show resolved
Hide resolved
prism-agent/src/commonMain/kotlin/io/iohk/atala/prism/walletsdk/prismagent/ConnectionManager.kt
Outdated
Show resolved
Hide resolved
...ommonMain/kotlin/io/iohk/atala/prism/walletsdk/prismagent/mediation/BasicMediationHandler.kt
Outdated
Show resolved
Hide resolved
import kotlinx.coroutines.flow.flow | ||
import kotlinx.coroutines.flow.map | ||
|
||
final class BasicMediationHandler( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we going to have multiple MediationHandler
implementations? If not, why Basic
instead of MediatorHandlerImpl
?
Just curious, if I see Basic
I would expect a Custom
or Advanced
or something more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It depends on @goncalo-frade-iohk answer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah we can change the name. This is basically an implementation we provide but the developer can provide any implementation that he desires.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. In that case in my opinion would make more sense to name it DefaultMediationHandler
, if a user wants to use its own implementation fine, if not we have our default implementation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
...ommonMain/kotlin/io/iohk/atala/prism/walletsdk/prismagent/mediation/BasicMediationHandler.kt
Outdated
Show resolved
Hide resolved
.../src/commonMain/kotlin/io/iohk/atala/prism/walletsdk/prismagent/mediation/MediatorHandler.kt
Outdated
Show resolved
Hide resolved
...nt/src/commonMain/kotlin/io/iohk/atala/prism/walletsdk/prismagent/mediation/MediatorStore.kt
Outdated
Show resolved
Hide resolved
...est/kotlin/io/iohk/atala/prism/walletsdk/prismagent/protocols/MediationKeysUpdateListTest.kt
Outdated
Show resolved
Hide resolved
@goncalo-frade-iohk @hamada147 @elribonazo left a bunch of comments, would like your opinion on those. |
352d230
to
504dc55
Compare
42d5ffd
to
9b0e8e1
Compare
6eb95d2
to
ee9a9ba
Compare
ee9a9ba
to
f7b5d7f
Compare
Need to add tests but since it is already a quite large PR. I will initiate a draft PR.