feat: connectionless credential offer #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cristian G <[email protected]>
cristianIOHK
requested review from
elribonazo,
curtis-h,
goncalo-frade-iohk and
amagyar-iohk
Signed-off-by: Cristian G <[email protected]>
Signed-off-by: Cristian G <[email protected]>
| ) | ||
|
|
||
| pluto.storeMessage(requestPresentation.makeMessage()) | ||
| connectionlessInvitation(ownDID, jsonString) |
There was a problem hiding this comment.
As we were talking yesterday this is not needed
There was a problem hiding this comment.
You need to parse and return the Credential Offer message
There was a problem hiding this comment.
I have changed the implementation. Please take another look.
Signed-off-by: Cristian G <[email protected]>
curtis-h
approved these changes
Sep 19, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds support for connectionless credential offer. It adds logic to extract all relevan data to form a message than it is used for any connectionless operation.
Checklist: