Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pollus JWT to support KID parameter #195

Merged
merged 4 commits into from
Sep 16, 2024
Merged

Conversation

cristianIOHK
Copy link
Contributor

Description:

This PR adds support for KID parameter to the JWT sign process as part of the header.

BREAKING CHANGE: Pollux methods changed to suspend as they have network calls on them.
processCredentialRequestJWT and processCredentialRequestSDJWT

Checklist:

  • My PR follows the contribution guidelines of this project
  • My PR is free of third-party dependencies that don't comply with the Allowlist
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked the PR title to follow the conventional commit specification

Copy link

github-actions bot commented Sep 3, 2024

Unit Test Results

151 tests  +1   148 ✅ +1   6s ⏱️ -1s
 26 suites ±0     3 💤 ±0 
 26 files   ±0     0 ❌ ±0 

Results for commit 78e72c6. ± Comparison against base commit 93d21c8.

♻️ This comment has been updated with latest results.

@cristianIOHK cristianIOHK merged commit 8ad7a91 into main Sep 16, 2024
6 checks passed
@cristianIOHK cristianIOHK deleted the feature/ATL-7641 branch September 16, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants