Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: refactor component constructor to accept logger #194

Merged
merged 5 commits into from
Sep 16, 2024

Conversation

cristianIOHK
Copy link
Contributor

Description:

This PR enhances the logger to work as an injected dependency into all 6 components, Apollo, Pollux, Pluto, Mercury, Castor and Agent. Allowing you to configure the Logger component, logger level and tag.

Checklist:

  • My PR follows the contribution guidelines of this project
  • My PR is free of third-party dependencies that don't comply with the Allowlist
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked the PR title to follow the conventional commit specification

Copy link

github-actions bot commented Aug 27, 2024

Unit Test Results

150 tests  ±0   147 ✅ ±0   7s ⏱️ -1s
 26 suites ±0     3 💤 ±0 
 26 files   ±0     0 ❌ ±0 

Results for commit a8c2b74. ± Comparison against base commit 90530a2.

♻️ This comment has been updated with latest results.

@cristianIOHK cristianIOHK merged commit 93d21c8 into main Sep 16, 2024
6 checks passed
@cristianIOHK cristianIOHK deleted the refactor/ATL-7558 branch September 16, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants