Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: increase test coverage #179

Merged
merged 5 commits into from
Aug 11, 2024
Merged

Conversation

cristianIOHK
Copy link
Contributor

@cristianIOHK cristianIOHK commented Aug 1, 2024

Description:

This PR increases the number of unit tests to improve the code coverage.

Checklist:

  • My PR follows the contribution guidelines of this project
  • My PR is free of third-party dependencies that don't comply with the Allowlist
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked the PR title to follow the conventional commit specification

Copy link

github-actions bot commented Aug 1, 2024

Unit Test Results

141 tests  +32   138 ✅ +32   7s ⏱️ ±0s
 25 suites + 1     3 💤 ± 0 
 25 files   + 1     0 ❌ ± 0 

Results for commit 754808f. ± Comparison against base commit 8bdb59b.

♻️ This comment has been updated with latest results.

@cristianIOHK cristianIOHK marked this pull request as ready for review August 1, 2024 20:00
@coveralls
Copy link

coveralls commented Aug 1, 2024

Pull Request Test Coverage Report for Build 10324495092

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 25 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.9%) to 43.907%

Files with Coverage Reduction New Missed Lines %
org/hyperledger/identus/walletsdk/pluto/PlutoImpl.kt 25 70.62%
Totals Coverage Status
Change from base Build 10288062413: 0.9%
Covered Lines: 3080
Relevant Lines: 6103

💛 - Coveralls

@cristianIOHK cristianIOHK force-pushed the chore/increase_test_coverage branch from 21720b4 to 5e3001b Compare August 7, 2024 19:14
@cristianIOHK cristianIOHK merged commit 7fede0f into main Aug 11, 2024
5 checks passed
@cristianIOHK cristianIOHK deleted the chore/increase_test_coverage branch August 11, 2024 20:46
cristianIOHK added a commit that referenced this pull request Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants