feat: VC Verification Audiance check #969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CryptoKnightIOG
requested review from
bvoiturier,
yshyn-iohk,
patlo-iog and
mineme0110
as code owners
CryptoKnightIOG
force-pushed
the
ATL-6782-Aud-check
branch
from
e0f74f1 to
539bc62
Compare
Integration Test Results13 files 13 suites 2s ⏱️ Results for commit bcd0152. ♻️ This comment has been updated with latest results. |
Unit Test Results 90 files 90 suites 21m 2s ⏱️ Results for commit bcd0152. ♻️ This comment has been updated with latest results. |
yshyn-iohk
approved these changes
Apr 16, 2024
yshyn-iohk
reviewed
Apr 16, 2024
| request.verifications.map(verification => | ||
| for { | ||
| serviceVerification <- VcVerification.convert( | ||
| verification.verification, |
There was a problem hiding this comment.
it would be nice to have a different names for the object (verification) and internal field (verification).
There was a problem hiding this comment.
will fix it in follow up
yshyn-iohk
approved these changes
Apr 16, 2024
Base automatically changed from
ATL-6785-6789-Semantic-Subject-Verification
to
VC-Verification-API
April 16, 2024 13:11
Signed-off-by: Bassam Riman <[email protected]>
CryptoKnightIOG
force-pushed
the
ATL-6782-Aud-check
branch
from
539bc62 to
bcd0152
Compare
CryptoKnightIOG
added a commit
that referenced
this pull request
Apr 16, 2024
Signed-off-by: Bassam Riman <[email protected]>
CryptoKnightIOG
added a commit
that referenced
this pull request
Apr 21, 2024
Signed-off-by: Bassam Riman <[email protected]>
CryptoKnightIOG
added a commit
that referenced
this pull request
Apr 23, 2024
Signed-off-by: Bassam Riman <[email protected]>
CryptoKnightIOG
added a commit
that referenced
this pull request
Apr 24, 2024
Signed-off-by: Bassam Riman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://input-output.atlassian.net/browse/ATL-6782