feat: VC Verification API Algorithm Issuer Verification #962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bassam Riman <[email protected]>
CryptoKnightIOG
changed the title
Integration Test Results13 files 13 suites 2s ⏱️ Results for commit 93c8d1e. |
Unit Test Results 90 files 90 suites 20m 49s ⏱️ Results for commit 93c8d1e. |
yshyn-iohk
reviewed
Apr 10, 2024
| .fromOptionWith("An algorithm must be specified in the header")(JwtCirce.parseHeader(header).algorithm) | ||
| result <- | ||
| Validation | ||
| .fromPredicateWith("No PublicKey to validate against found")( |
There was a problem hiding this comment.
As far as I know, the public key might be missed in the header.
In this case, kid (key ID) is used and should be resolved in the DID document.
@CryptoKnightIOG, could you check the JWT spec to clarify this case?
yshyn-iohk
approved these changes
Apr 10, 2024
CryptoKnightIOG
added a commit
that referenced
this pull request
Apr 16, 2024
Signed-off-by: Bassam Riman <[email protected]>
CryptoKnightIOG
added a commit
that referenced
this pull request
Apr 21, 2024
Signed-off-by: Bassam Riman <[email protected]>
CryptoKnightIOG
added a commit
that referenced
this pull request
Apr 23, 2024
Signed-off-by: Bassam Riman <[email protected]>
CryptoKnightIOG
added a commit
that referenced
this pull request
Apr 24, 2024
Signed-off-by: Bassam Riman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
https://input-output.atlassian.net/browse/ATL-6787
https://input-output.atlassian.net/browse/ATL-6779