Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(prism-agent): add verification policy OpenAPI description #835

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

yshyn-iohk
Copy link
Member

@yshyn-iohk yshyn-iohk commented Jan 9, 2024

Overview

Fixes ATL-6268 - improve OpenAPI specification for Verification Policies API

Checklist

My PR contains...

  • No code changes (changes to documentation, CI, metadata, etc.)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes
  • are not breaking changes
  • If yes to above: I have updated the documentation accordingly

Documentation

  • My changes do not require a change to the project documentation
  • My changes require a change to the project documentation
  • If yes to above: I have updated the documentation accordingly

Tests

  • My changes can not or do not need to be tested
  • My changes can and should be tested by unit and/or integration tests
  • If yes to above: I have added tests to cover my changes
  • If yes to above: I have taken care to cover edge cases in my tests

@yshyn-iohk yshyn-iohk force-pushed the ATL-6268-oas-verification-policies branch from 067ee4a to 38594fa Compare January 9, 2024 16:03
@yshyn-iohk yshyn-iohk requested a review from patlo-iog January 9, 2024 16:03
Copy link

sonarqubecloud bot commented Jan 9, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

5 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@yshyn-iohk yshyn-iohk requested a review from mineme0110 January 9, 2024 16:04
Copy link
Contributor

github-actions bot commented Jan 9, 2024

Integration Test Results

11 files  ±0  11 suites  ±0   2s ⏱️ ±0s
24 tests ±0  24 ✅ ±0  0 💤 ±0  0 ❌ ±0 
25 runs  ±0  25 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 38594fa. ± Comparison against base commit 614e811.

Copy link
Contributor

github-actions bot commented Jan 9, 2024

Unit Test Results

 85 files  ±0   85 suites  ±0   21m 17s ⏱️ +12s
713 tests ±0  705 ✅ ±0  8 💤 ±0  0 ❌ ±0 
719 runs  ±0  711 ✅ ±0  8 💤 ±0  0 ❌ ±0 

Results for commit 38594fa. ± Comparison against base commit 614e811.

Copy link
Contributor

@bvoiturier bvoiturier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more step in the right direction! Well done @yshyn-iohk 💪

@yshyn-iohk yshyn-iohk merged commit b48fe3c into main Jan 10, 2024
11 checks passed
@yshyn-iohk yshyn-iohk deleted the ATL-6268-oas-verification-policies branch January 10, 2024 09:05
shotexa pushed a commit that referenced this pull request Mar 6, 2024
shotexa pushed a commit that referenced this pull request Mar 6, 2024
shotexa pushed a commit that referenced this pull request Mar 18, 2024
shotexa pushed a commit that referenced this pull request Mar 18, 2024
shotexa pushed a commit that referenced this pull request Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants