Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: make sbt-license-report more fault tolerance with ivy unresolved dependencies #803

Merged
merged 7 commits into from
Dec 4, 2023

Conversation

patlo-iog
Copy link
Contributor

@patlo-iog patlo-iog commented Dec 4, 2023

Overview

Fixes ATL-6173

Upgrade new version of sbt-license-report plugin that provides DependencyResolution interface. Override that interface with an implementation that will not fail when resolving license information. Now we don't need to manually list versions that ivy is unable to resolve.

Checklist

My PR contains...

  • No code changes (changes to documentation, CI, metadata, etc.)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes
  • are not breaking changes
  • If yes to above: I have updated the documentation accordingly

Documentation

  • My changes do not require a change to the project documentation
  • My changes require a change to the project documentation
  • If yes to above: I have updated the documentation accordingly

Tests

  • My changes can not or do not need to be tested
  • My changes can and should be tested by unit and/or integration tests
  • If yes to above: I have added tests to cover my changes
  • If yes to above: I have taken care to cover edge cases in my tests

Pat Losoponkul added 6 commits December 1, 2023 18:37
Signed-off-by: Pat Losoponkul <[email protected]>
Signed-off-by: Pat Losoponkul <[email protected]>
Signed-off-by: Pat Losoponkul <[email protected]>
Signed-off-by: Pat Losoponkul <[email protected]>
Signed-off-by: Pat Losoponkul <[email protected]>
Signed-off-by: Pat Losoponkul <[email protected]>
@patlo-iog patlo-iog changed the title build: make sbt-license-report more fault tolerance with dependencies build: make sbt-license-report more fault tolerance with our dependencies Dec 4, 2023
@patlo-iog patlo-iog changed the title build: make sbt-license-report more fault tolerance with our dependencies build: make sbt-license-report more fault tolerance with ivy unresolved dependencies Dec 4, 2023
Copy link
Contributor

github-actions bot commented Dec 4, 2023

Integration Test Results

11 files  ±0  11 suites  ±0   2s ⏱️ ±0s
24 tests ±0  24 ✔️ ±0  0 💤 ±0  0 ±0 
25 runs  ±0  25 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 7461f43. ± Comparison against base commit c49c813.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Dec 4, 2023

Unit Test Results

  85 files  ±0    85 suites  ±0   20m 52s ⏱️ -58s
713 tests ±0  705 ✔️ ±0  8 💤 ±0  0 ±0 
719 runs  ±0  711 ✔️ ±0  8 💤 ±0  0 ±0 

Results for commit 7461f43. ± Comparison against base commit c49c813.

♻️ This comment has been updated with latest results.

Signed-off-by: Pat Losoponkul <[email protected]>
@patlo-iog patlo-iog force-pushed the fix/ivy-manual-deps branch from 73d8ec1 to 7461f43 Compare December 4, 2023 08:17
Copy link

sonarqubecloud bot commented Dec 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link

@antonbaliasnikov antonbaliasnikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for fixing this!

@patlo-iog patlo-iog merged commit f1b4904 into main Dec 4, 2023
12 checks passed
@patlo-iog patlo-iog deleted the fix/ivy-manual-deps branch December 4, 2023 08:42
shotexa pushed a commit that referenced this pull request Dec 5, 2023
…ed dependencies (#803)

Signed-off-by: Pat Losoponkul <[email protected]>
Signed-off-by: Shota Jolbordi <[email protected]>
shotexa pushed a commit that referenced this pull request Mar 6, 2024
…ed dependencies (#803)

Signed-off-by: Pat Losoponkul <[email protected]>
Signed-off-by: Shota Jolbordi <[email protected]>
shotexa pushed a commit that referenced this pull request Mar 6, 2024
…ed dependencies (#803)

Signed-off-by: Pat Losoponkul <[email protected]>
Signed-off-by: Shota Jolbordi <[email protected]>
shotexa pushed a commit that referenced this pull request Mar 18, 2024
…ed dependencies (#803)

Signed-off-by: Pat Losoponkul <[email protected]>
Signed-off-by: Shota Jolbordi <[email protected]>
shotexa pushed a commit that referenced this pull request Mar 18, 2024
…ed dependencies (#803)

Signed-off-by: Pat Losoponkul <[email protected]>
Signed-off-by: Shota Jolbordi <[email protected]>
shotexa pushed a commit that referenced this pull request Mar 18, 2024
…ed dependencies (#803)

Signed-off-by: Pat Losoponkul <[email protected]>
Signed-off-by: Shota Jolbordi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants