fix(prism-agent): check issuing DID validity when creating a VC offer #740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yshyn-iohk
reviewed
Oct 2, 2023
...agent/service/server/src/main/scala/io/iohk/atala/issue/controller/IssueControllerImpl.scala
Show resolved
Hide resolved
yshyn-iohk
approved these changes
Oct 2, 2023
|
Good job, @bvoiturier! Don't forget about DCO (it's now required) |
|
Something to note, the e2e tests has green check, but not all the tests pass. |
…known by the agent and not deactivated Signed-off-by: Benjamin Voiturier <[email protected]>
Signed-off-by: Milos Backonja <[email protected]> Signed-off-by: Benjamin Voiturier <[email protected]>
## [1.16.4](prism-agent-v1.16.3...prism-agent-v1.16.4) (2023-09-29) ### Bug Fixes * Integration flow ATL-5777 ([#738](#738)) ([7cf927c](7cf927c)) Signed-off-by: Anton Baliasnikov <[email protected]> Signed-off-by: Benjamin Voiturier <[email protected]>
Signed-off-by: Benjamin Voiturier <[email protected]>
… failure in REST endpoint response Signed-off-by: Benjamin Voiturier <[email protected]>
Signed-off-by: Benjamin Voiturier <[email protected]>
Signed-off-by: Pat Losoponkul <[email protected]> Signed-off-by: Benjamin Voiturier <[email protected]>
…tion endpoints response Signed-off-by: Benjamin Voiturier <[email protected]>
Signed-off-by: Benjamin Voiturier <[email protected]>
Signed-off-by: Benjamin Voiturier <[email protected]>
bvoiturier
force-pushed
the
tech-debt/ATL-4241-reject-unknown-or-deactivated-did-on-vc-offer-creation
branch
from
e775faa to
396100a
Compare
…ated-did-on-vc-offer-creation
Signed-off-by: Benjamin Voiturier <[email protected]>
bvoiturier
deleted the
tech-debt/ATL-4241-reject-unknown-or-deactivated-did-on-vc-offer-creation
branch
shotexa
pushed a commit
that referenced
this pull request
Oct 2, 2023
…r + return 'metaRetries' (#740) Signed-off-by: Benjamin Voiturier <[email protected]> Signed-off-by: Milos Backonja <[email protected]> Signed-off-by: Anton Baliasnikov <[email protected]> Signed-off-by: Pat Losoponkul <[email protected]> Co-authored-by: Milos Backonja <[email protected]> Co-authored-by: atala-dev <[email protected]> Co-authored-by: patlo-iog <[email protected]>
shotexa
pushed a commit
that referenced
this pull request
Oct 2, 2023
…r + return 'metaRetries' (#740) Signed-off-by: Benjamin Voiturier <[email protected]> Signed-off-by: Milos Backonja <[email protected]> Signed-off-by: Anton Baliasnikov <[email protected]> Signed-off-by: Pat Losoponkul <[email protected]> Co-authored-by: Milos Backonja <[email protected]> Co-authored-by: atala-dev <[email protected]> Co-authored-by: patlo-iog <[email protected]> Signed-off-by: Shota Jolbordi <[email protected]>
atala-dev
added a commit
that referenced
this pull request
Oct 14, 2023
# [1.17.0](prism-agent-v1.16.4...prism-agent-v1.17.0) (2023-10-14) ### Bug Fixes * change repository and name for rest api clients ([#745](#745)) ([0f84e28](0f84e28)) * improve performance for background jobs in multitenancy mode ([#749](#749)) ([17def3f](17def3f)) * **prism-agent:** agent should read DIDComm port from config ([#757](#757)) ([cda908c](cda908c)) * **prism-agent:** configure APISIX to return CORS headers from Prism Agent endpoints ([#746](#746)) ([a579aa9](a579aa9)) * **prism-agent:** fix docker env variables interpolation issue ([#751](#751)) ([110eb2d](110eb2d)) * **prism-agent:** return relevant errors on offer creation ([#754](#754)) ([d36533f](d36533f)) * prohibit tenants to use equal or revoked api keys ([#742](#742)) ([4b10c3a](4b10c3a)) * upgrade vault and quill versions ([#739](#739)) ([c140857](c140857)) ### Features * **prism-agent:** check issuing DID validity when creating a VC offer + return 'metaRetries' ([#740](#740)) ([f2e2fd3](f2e2fd3)) * **prism-agent:** implement AnonCreds issuance flow ([#693](#693)) ([9165a6f](9165a6f)) Signed-off-by: Anton Baliasnikov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes ATL-4241
Fixes ATL-5573
Checklist
My PR contains...
My changes...
Documentation
Tests