Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add prism-agent client generator #608

Merged
merged 12 commits into from
Aug 4, 2023
Merged

Conversation

amagyar-iohk
Copy link
Contributor

@amagyar-iohk amagyar-iohk commented Aug 1, 2023

Overview

Fixes ATL-xxxx

Checklist

My PR contains...

  • No code changes (changes to documentation, CI, metadata, etc.)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes
  • are not breaking changes
  • If yes to above: I have updated the documentation accordingly

Documentation

  • My changes do not require a change to the project documentation
  • My changes require a change to the project documentation
  • If yes to above: I have updated the documentation accordingly

Tests

  • My changes can not or do not need to be tested
  • My changes can and should be tested by unit and/or integration tests
  • If yes to above: I have added tests to cover my changes
  • If yes to above: I have taken care to cover edge cases in my tests

@amagyar-iohk amagyar-iohk changed the title Feat/generate oas client ci: add prism-agent client generator Aug 1, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2023

Atala PRISM Test Results

  63 files  ±0    63 suites  ±0   8m 7s ⏱️ +5s
531 tests ±0  520 ✔️ ±0  11 💤 ±0  0 ±0 
534 runs  ±0  523 ✔️ ±0  11 💤 ±0  0 ±0 

Results for commit 39ffbae. ± Comparison against base commit faa869a.

♻️ This comment has been updated with latest results.

Copy link

@antonbaliasnikov antonbaliasnikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, remove .gradle directory

prism-agent/client/generator/package.json Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication


# Caution note

Some of the OAS3 schema types are not fully supported.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amagyar-iohk, can you create a ticket with details about OAS3 incompatibility?

Copy link
Member

@yshyn-iohk yshyn-iohk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking forward to this improvement :)
good job @amagyar-iohk!

@amagyar-iohk, can you show the incompatibilities in OAS to @patlo-iog
He might figure out how to fix it without hacks (if it's possible).

@antonbaliasnikov antonbaliasnikov merged commit 5b7afbe into main Aug 4, 2023
@antonbaliasnikov antonbaliasnikov deleted the feat/generate-oas-client branch August 4, 2023 08:43
amagyar-iohk added a commit that referenced this pull request Aug 18, 2023
…po subject to the Developer Certificate of Origin (DCO), Version 1.1.

de56d4e ci: fix typescript client (#614)
5b7afbe ci: add prism-agent client generator (#608)
c075cd6 tests: add bdd scenarios for /did-registrar/dids endpoints (#230)
17038d3 fix(infra): adds execution chmod to init-script (#220)

Signed-off-by: Allain Magyar <[email protected]>
antonbaliasnikov pushed a commit that referenced this pull request Aug 21, 2023
…po subject to the Developer Certificate of Origin (DCO), Version 1.1.

de56d4e ci: fix typescript client (#614)
5b7afbe ci: add prism-agent client generator (#608)
c075cd6 tests: add bdd scenarios for /did-registrar/dids endpoints (#230)
17038d3 fix(infra): adds execution chmod to init-script (#220)

Signed-off-by: Allain Magyar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants