Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: clean imports warnings #594

Merged
merged 1 commit into from
Jul 14, 2023
Merged

chore: clean imports warnings #594

merged 1 commit into from
Jul 14, 2023

Conversation

CryptoKnightIOG
Copy link
Contributor

@CryptoKnightIOG CryptoKnightIOG commented Jul 14, 2023 •
edited
Loading

Overview

Fixes ATL-xxxx

Checklist

My PR contains...

  • No code changes (changes to documentation, CI, metadata, etc.)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes
  • are not breaking changes
  • If yes to above: I have updated the documentation accordingly

Documentation

  • My changes do not require a change to the project documentation
  • My changes require a change to the project documentation
  • If yes to above: I have updated the documentation accordingly

Tests

  • My changes can not or do not need to be tested
  • My changes can and should be tested by unit and/or integration tests
  • If yes to above: I have added tests to cover my changes
  • If yes to above: I have taken care to cover edge cases in my tests

@github-actions
Copy link
Contributor

github-actions bot commented Jul 14, 2023 •
edited
Loading

Atala PRISM Test Results

  63 files  ±0    63 suites  ±0   8m 4s ⏱️ -36s
524 tests ±0  513 ✔️ ±0  11 💤 ±0  0 ❌ ±0 
527 runs  ±0  516 ✔️ ±0  11 💤 ±0  0 ❌ ±0 

Results for commit cc986d3. ± Comparison against base commit a1e457a.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

E2E Test Results

11 files  ±0  11 suites  ±0   6m 2s ⏱️ -17s
21 tests ±0  21 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
32 runs  ±0  32 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit c8ec3df. ± Comparison against base commit 47b273a.

@CryptoKnightIOG CryptoKnightIOG merged commit 8a1f5de into main Jul 14, 2023
@CryptoKnightIOG CryptoKnightIOG deleted the tech-debt branch July 14, 2023 14:03
CryptoKnightIOG added a commit that referenced this pull request Aug 21, 2023
@CryptoKnightIOG
I, Bassam Riman hereby sign-off-by all of my past commits to this rep…
9f6bb2c 
…o subject to the Developer Certificate of Origin (DCO), Version 1.1.

8a1f5de chore: clean imports warnings (#594)
a57deef feat: ATL-4888 Anoncred schema type (#590)
4b8a54f chore: clean warnings (#580)
3c2f7a0 chore: refactor schema to support multiple credential types (#579)
495d0d0 chore: tech-debt clean up all warnings (#564)
e5225b7 fix(pollux): ATL-3971 Fix all Deprecation Warning (#506)
5b4aa5d fix(pollux): ATL-3900 Force use of Bouncycastle (#463)
d0c36f4 feat(pollux): [ATL-2706] Universal Verification Method (#258)
01af7c8 feat(pollux): [ATL-2733] Allow for dates in seconds for exp, iss and iat (#249)
6348e13 feat(pollux): [ATL-2679] Improve Error Hanlding and Verification (#239)
202f565 feat(pollux): [ATL-2643] Verify All JWT Presentation Enclosed Credentials (#221)
258c6c0 feat(pollux): [ATL-2640] JWT Presentation Signature Verification Using DidResolver (#212)
4ff51b6 feat(pollux): [ATL-2639] JWT Presentation Temporal Verification (#204)
42d23fb feat(pollux): [ATL-2235] Verfiable Prensentation Adjustments (#201)
f493ba9 [ATL-2501] feat(pollux): JWT Temporal Verification (#188)
5981a77 [ATL-2427] feat(pollux): Simplify DIDDocument Resolution and Schema Valdiation (#174)
79fbd86 [ATL-2427] feat(pollux): Resolve DID and Verify Signature in JWT Credential (#151)
3804e31 [ATL-1999] feat(pollux): Segregated Resolver (#114)
e0869f7 feat(pollux): Add JWT Verifiable Credential Validation (#83) [ATL-1999]
4bbe6bc [ATL-1932] feat(pollux): added Verifiable Presentation Demo (#70)
de2af2f ATL-1932: Create JWT Verifiable Presentation (#69)
c4440df [ATL-1342] feat(pollux): Credential Json Decoding. JWT Crendential Encoding and Validation (#65)
7108401 [ATL-1342] feat(pollux): Created JWT Verifiable Credential (#55)
e3ee7ab [ATL-1342] feat(pollux): Added JSON Schema (#44)
71b7116 [ATL-1342] feat(pollux): initialise VC JWT (#42)
089482d [ATL-1808] doc(castor): Adjust-Castor-OpenAPI-Spec (#27)
d898fc4 doc(castor): Added Castor DID OpenAPI Specs (#9)

Signed-off-by: Bassam Riman <[email protected]>
@CryptoKnightIOG CryptoKnightIOG mentioned this pull request Aug 21, 2023
Merged
14 tasks
CryptoKnightIOG added a commit that referenced this pull request Aug 21, 2023
@CryptoKnightIOG
I, Bassam Riman hereby sign-off-by all of my past commits to this rep…
c061976 
…o subject to the Developer Certificate of Origin (DCO), Version 1.1.

8a1f5de chore: clean imports warnings (#594)
a57deef feat: ATL-4888 Anoncred schema type (#590)
4b8a54f chore: clean warnings (#580)
3c2f7a0 chore: refactor schema to support multiple credential types (#579)
495d0d0 chore: tech-debt clean up all warnings (#564)
e5225b7 fix(pollux): ATL-3971 Fix all Deprecation Warning (#506)
5b4aa5d fix(pollux): ATL-3900 Force use of Bouncycastle (#463)
d0c36f4 feat(pollux): [ATL-2706] Universal Verification Method (#258)
01af7c8 feat(pollux): [ATL-2733] Allow for dates in seconds for exp, iss and iat (#249)
6348e13 feat(pollux): [ATL-2679] Improve Error Hanlding and Verification (#239)
202f565 feat(pollux): [ATL-2643] Verify All JWT Presentation Enclosed Credentials (#221)
258c6c0 feat(pollux): [ATL-2640] JWT Presentation Signature Verification Using DidResolver (#212)
4ff51b6 feat(pollux): [ATL-2639] JWT Presentation Temporal Verification (#204)
42d23fb feat(pollux): [ATL-2235] Verfiable Prensentation Adjustments (#201)
f493ba9 [ATL-2501] feat(pollux): JWT Temporal Verification (#188)
5981a77 [ATL-2427] feat(pollux): Simplify DIDDocument Resolution and Schema Valdiation (#174)
79fbd86 [ATL-2427] feat(pollux): Resolve DID and Verify Signature in JWT Credential (#151)
3804e31 [ATL-1999] feat(pollux): Segregated Resolver (#114)
e0869f7 feat(pollux): Add JWT Verifiable Credential Validation (#83) [ATL-1999]
4bbe6bc [ATL-1932] feat(pollux): added Verifiable Presentation Demo (#70)
de2af2f ATL-1932: Create JWT Verifiable Presentation (#69)
c4440df [ATL-1342] feat(pollux): Credential Json Decoding. JWT Crendential Encoding and Validation (#65)
7108401 [ATL-1342] feat(pollux): Created JWT Verifiable Credential (#55)
e3ee7ab [ATL-1342] feat(pollux): Added JSON Schema (#44)
71b7116 [ATL-1342] feat(pollux): initialise VC JWT (#42)
089482d [ATL-1808] doc(castor): Adjust-Castor-OpenAPI-Spec (#27)
d898fc4 doc(castor): Added Castor DID OpenAPI Specs (#9)

Signed-off-by: Bassam Riman <[email protected]>
antonbaliasnikov pushed a commit that referenced this pull request Aug 21, 2023
@CryptoKnightIOG
I, Bassam Riman hereby sign-off-by all of my past commits to this rep…
3c38dae 
…o subject to the Developer Certificate of Origin (DCO), Version 1.1.

8a1f5de chore: clean imports warnings (#594)
a57deef feat: ATL-4888 Anoncred schema type (#590)
4b8a54f chore: clean warnings (#580)
3c2f7a0 chore: refactor schema to support multiple credential types (#579)
495d0d0 chore: tech-debt clean up all warnings (#564)
e5225b7 fix(pollux): ATL-3971 Fix all Deprecation Warning (#506)
5b4aa5d fix(pollux): ATL-3900 Force use of Bouncycastle (#463)
d0c36f4 feat(pollux): [ATL-2706] Universal Verification Method (#258)
01af7c8 feat(pollux): [ATL-2733] Allow for dates in seconds for exp, iss and iat (#249)
6348e13 feat(pollux): [ATL-2679] Improve Error Hanlding and Verification (#239)
202f565 feat(pollux): [ATL-2643] Verify All JWT Presentation Enclosed Credentials (#221)
258c6c0 feat(pollux): [ATL-2640] JWT Presentation Signature Verification Using DidResolver (#212)
4ff51b6 feat(pollux): [ATL-2639] JWT Presentation Temporal Verification (#204)
42d23fb feat(pollux): [ATL-2235] Verfiable Prensentation Adjustments (#201)
f493ba9 [ATL-2501] feat(pollux): JWT Temporal Verification (#188)
5981a77 [ATL-2427] feat(pollux): Simplify DIDDocument Resolution and Schema Valdiation (#174)
79fbd86 [ATL-2427] feat(pollux): Resolve DID and Verify Signature in JWT Credential (#151)
3804e31 [ATL-1999] feat(pollux): Segregated Resolver (#114)
e0869f7 feat(pollux): Add JWT Verifiable Credential Validation (#83) [ATL-1999]
4bbe6bc [ATL-1932] feat(pollux): added Verifiable Presentation Demo (#70)
de2af2f ATL-1932: Create JWT Verifiable Presentation (#69)
c4440df [ATL-1342] feat(pollux): Credential Json Decoding. JWT Crendential Encoding and Validation (#65)
7108401 [ATL-1342] feat(pollux): Created JWT Verifiable Credential (#55)
e3ee7ab [ATL-1342] feat(pollux): Added JSON Schema (#44)
71b7116 [ATL-1342] feat(pollux): initialise VC JWT (#42)
089482d [ATL-1808] doc(castor): Adjust-Castor-OpenAPI-Spec (#27)
d898fc4 doc(castor): Added Castor DID OpenAPI Specs (#9)

Signed-off-by: Bassam Riman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patlo-iog patlo-iog patlo-iog approved these changes

@yshyn-iohk yshyn-iohk yshyn-iohk approved these changes

@bvoiturier bvoiturier Awaiting requested review from bvoiturier

@mineme0110 mineme0110 Awaiting requested review from mineme0110

Assignees
No one assigned
Labels
Component: Cloud Agent
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CryptoKnightIOG @yshyn-iohk @patlo-iog @atala-dev