Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: createCredentialIssueRecordRequest schemaId field to be Option[String] #1481

Merged
merged 3 commits into from
Dec 16, 2024

Conversation

yshyn-iohk
Copy link
Member

Description:

This refactoring is required because the schemaId property should never accept the value of a string array for currently supported VC types. The corresponding objects should be used to create VCDM 1.1 and VCDM 2.0 VCs.

Checklist:

  • My PR follows the contribution guidelines of this project
  • My PR is free of third-party dependencies that don't comply with the Allowlist
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked the PR title to follow the conventional commit specification

@yshyn-iohk yshyn-iohk requested a review from a team as a code owner December 16, 2024 12:52
Copy link
Contributor

github-actions bot commented Dec 16, 2024

Integration Test Results

20 files  ±0  20 suites  ±0   2s ⏱️ ±0s
55 tests ±0  55 ✅ ±0  0 💤 ±0  0 ❌ ±0 
97 runs  ±0  97 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit dc98dcf. ± Comparison against base commit 2fb833a.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Dec 16, 2024

Unit Test Results

104 files  ±0  104 suites  ±0   20m 55s ⏱️ -2s
882 tests ±0  874 ✅ ±0  8 💤 ±0  0 ❌ ±0 
889 runs  ±0  881 ✅ ±0  8 💤 ±0  0 ❌ ±0 

Results for commit dc98dcf. ± Comparison against base commit 2fb833a.

♻️ This comment has been updated with latest results.

@coveralls
Copy link

coveralls commented Dec 16, 2024

Coverage Status

coverage: 48.743% (-0.05%) from 48.797%
when pulling dc98dcf on feat/vcdm-1_1-oas-refactoring
into 2fb833a on main.

@yshyn-iohk yshyn-iohk changed the title refactor: createCredentialIssueRecordRequest schemaId field to be Option[String] fix: createCredentialIssueRecordRequest schemaId field to be Option[String] Dec 16, 2024
@yshyn-iohk yshyn-iohk enabled auto-merge (squash) December 16, 2024 13:47
@yshyn-iohk yshyn-iohk merged commit 7524ec7 into main Dec 16, 2024
15 of 16 checks passed
@yshyn-iohk yshyn-iohk deleted the feat/vcdm-1_1-oas-refactoring branch December 16, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants