Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: disable the APIKEY authentication in the cloud-agent #1479

Merged
merged 3 commits into from
Dec 13, 2024

Conversation

yshyn-iohk
Copy link
Member

@yshyn-iohk yshyn-iohk commented Dec 12, 2024

Description:

Fixes #1478

Checklist:

  • My PR follows the contribution guidelines of this project
  • My PR is free of third-party dependencies that don't comply with the Allowlist
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked the PR title to follow the conventional commit specification

@yshyn-iohk yshyn-iohk requested a review from a team as a code owner December 12, 2024 12:04
Copy link
Contributor

github-actions bot commented Dec 12, 2024

Unit Test Results

104 files  ±0  104 suites  ±0   20m 33s ⏱️ +21s
882 tests ±0  874 ✅ ±0  8 💤 ±0  0 ❌ ±0 
889 runs  ±0  881 ✅ ±0  8 💤 ±0  0 ❌ ±0 

Results for commit ede9730. ± Comparison against base commit a96e544.

♻️ This comment has been updated with latest results.

@coveralls
Copy link

coveralls commented Dec 12, 2024

Coverage Status

coverage: 48.797%. remained the same
when pulling ede9730 on feat/1478-disable-apikey-authentication
into a96e544 on main.

@yshyn-iohk yshyn-iohk changed the title [WIP] feat: disable the APIKEY authentication in the cloud-agent feat: disable the APIKEY authentication in the cloud-agent Dec 13, 2024
@yshyn-iohk yshyn-iohk marked this pull request as draft December 13, 2024 11:05
@github-actions github-actions bot added the infra label Dec 13, 2024
@yshyn-iohk yshyn-iohk marked this pull request as ready for review December 13, 2024 11:59
@yshyn-iohk yshyn-iohk enabled auto-merge (squash) December 13, 2024 12:00
Copy link
Contributor

Integration Test Results

20 files  ±0  20 suites  ±0   3s ⏱️ -1s
55 tests ±0  55 ✅ ±0  0 💤 ±0  0 ❌ ±0 
97 runs  ±0  97 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit ede9730. ± Comparison against base commit a96e544.

@yshyn-iohk yshyn-iohk merged commit 2fb833a into main Dec 13, 2024
20 of 22 checks passed
@yshyn-iohk yshyn-iohk deleted the feat/1478-disable-apikey-authentication branch December 13, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

APIKEY authentication is disabled by default
3 participants