Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update the jwt to have shortform of prism did #1461

Merged
merged 9 commits into from
Nov 29, 2024

Conversation

mineme0110
Copy link
Contributor

@mineme0110 mineme0110 commented Nov 20, 2024

Description:

Update the JWT to use the short-form DID in the iss field instead of the long-form DID.
#1451

Alternatives Considered (optional):

Link to existing ADR (Architecture Decision Record), if any. If relevant, describe other approaches explored and the selected approach. Documenting why the methods were not selected will create a knowledge base for future reference, helping prevent others from revisiting less optimal ideas.

Checklist:

  • My PR follows the contribution guidelines of this project
  • My PR is free of third-party dependencies that don't comply with the Allowlist
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked the PR title to follow the conventional commit specification

@elribonazo
Copy link
Contributor

Reminder to use breaking change for this case as it will break implementations in the SDK's if people don't have a custom resolver

Copy link
Contributor

github-actions bot commented Nov 20, 2024

Integration Test Results

20 files  ±0  20 suites  ±0   2s ⏱️ ±0s
56 tests ±0  56 ✅ ±0  0 💤 ±0  0 ❌ ±0 
98 runs  ±0  98 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit dbd3aa5. ± Comparison against base commit 5ece0dd.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Nov 20, 2024

Unit Test Results

104 files  ±0  104 suites  ±0   20m 39s ⏱️ + 1m 13s
882 tests ±0  874 ✅ ±0  8 💤 ±0  0 ❌ ±0 
889 runs  ±0  881 ✅ ±0  8 💤 ±0  0 ❌ ±0 

Results for commit dbd3aa5. ± Comparison against base commit 5ece0dd.

♻️ This comment has been updated with latest results.

@coveralls
Copy link

coveralls commented Nov 20, 2024

Coverage Status

coverage: 48.796% (-0.06%) from 48.859%
when pulling dbd3aa5 on fix/issuer-shortform-did
into 5ece0dd on main.

@mineme0110 mineme0110 force-pushed the fix/issuer-shortform-did branch from 5aca5d7 to 473acf9 Compare November 20, 2024 21:51
@mineme0110 mineme0110 force-pushed the fix/issuer-shortform-did branch from dc275f0 to ae0686c Compare November 25, 2024 10:22
@github-actions github-actions bot added the infra label Nov 25, 2024
@github-actions github-actions bot added the ci label Nov 25, 2024
mineme0110 and others added 4 commits November 27, 2024 12:35
Signed-off-by: Hyperledger Bot <[email protected]>
Co-authored-by: Hyperledger Bot <[email protected]>
Signed-off-by: mineme0110 <[email protected]>
Signed-off-by: Hyperledger Bot <[email protected]>
Co-authored-by: Hyperledger Bot <[email protected]>
@yshyn-iohk yshyn-iohk merged commit 7365497 into main Nov 29, 2024
16 of 17 checks passed
@yshyn-iohk yshyn-iohk deleted the fix/issuer-shortform-did branch November 29, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants