Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add new tests and refactoring #1442

Merged
merged 4 commits into from
Nov 20, 2024
Merged

test: add new tests and refactoring #1442

merged 4 commits into from
Nov 20, 2024

Conversation

amagyar-iohk
Copy link
Contributor

Description:

Adds more tests and refactoring

Checklist:

  • My PR follows the contribution guidelines of this project
  • My PR is free of third-party dependencies that don't comply with the Allowlist
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked the PR title to follow the conventional commit specification

Copy link
Contributor

github-actions bot commented Nov 15, 2024

Integration Test Results

20 files  ±0  20 suites  ±0   3s ⏱️ ±0s
56 tests +2  56 ✅ +2  0 💤 ±0  0 ❌ ±0 
98 runs  +3  98 ✅ +3  0 💤 ±0  0 ❌ ±0 

Results for commit 6c69755. ± Comparison against base commit 7839b95.

This pull request removes 10 and adds 12 tests. Note that renamed tests count towards both.
Create PRISM DID
Create PRISM DID with disallowed key purpose
Create issuer with <description> expect <httpStatus> response
Expected checks for generated JWT VC
Expected failures
Issuing jwt credential with published PRISM DID using Ed25519
Receive a jwt vc from cloud-agent and verify it
Schema creation should fail for cases
Unsupported verification check should fail
Update PRISM DID keys
Create PRISM DID with <curve> for <purpose>
Create PRISM DID with <curve> for <purpose> should not work
Create issuer with [id=<id>; url=<url>; clientId=<clientId>; clientSecret=<clientSecret>] expect <httpStatus> response
Holder presents sd-jwt out-of-band proof to <verifier>
Issuing jwt credential using <assertionMethod> assertion
Schema creation should fail for <schema_issue>
Unsupported verification <verification> check should fail
Update PRISM DID keys using <curve> for <purpose>
Verify a jwt credential using verification api
Verify a pre-generated jwt credential using verification api
…

♻️ This comment has been updated with latest results.

Copy link
Member

@yshyn-iohk yshyn-iohk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well done, @amagyar-iohk!

Copy link
Contributor

github-actions bot commented Nov 19, 2024

Unit Test Results

104 files  ±0  104 suites  ±0   20m 37s ⏱️ -11s
882 tests ±0  874 ✅ ±0  8 💤 ±0  0 ❌ ±0 
889 runs  ±0  881 ✅ ±0  8 💤 ±0  0 ❌ ±0 

Results for commit 6c69755. ± Comparison against base commit 7839b95.

♻️ This comment has been updated with latest results.

@coveralls
Copy link

coveralls commented Nov 19, 2024

Coverage Status

coverage: 48.848% (-0.006%) from 48.854%
when pulling 6c69755 on tests/crypto-merge
into 7839b95 on main.

@amagyar-iohk amagyar-iohk marked this pull request as ready for review November 19, 2024 12:51
@amagyar-iohk amagyar-iohk requested a review from a team as a code owner November 19, 2024 12:51
amagyar-iohk and others added 3 commits November 20, 2024 09:40
Signed-off-by: Allain Magyar <[email protected]>

test: finalized tests and refactoring

Signed-off-by: Allain Magyar <[email protected]>

Revert "fix: use Kafka 'earliest' offset strategy to avoid missing messages"

This reverts commit 241abe8.

Revert "chore: reduce Kafka clients lib log verbosity"

This reverts commit 8935889.

style: apply linters automatic fixes (#1449)

Signed-off-by: Hyperledger Bot <[email protected]>
Co-authored-by: Hyperledger Bot <[email protected]>

test: removes unused code

Signed-off-by: Allain Magyar <[email protected]>

style: apply linters automatic fixes (#1456)

Signed-off-by: Hyperledger Bot <[email protected]>
Co-authored-by: Hyperledger Bot <[email protected]>
Signed-off-by: Allain Magyar <[email protected]>
Signed-off-by: Allain Magyar <[email protected]>
Signed-off-by: Allain Magyar <[email protected]>
@amagyar-iohk amagyar-iohk merged commit 8781d3d into main Nov 20, 2024
13 checks passed
@amagyar-iohk amagyar-iohk deleted the tests/crypto-merge branch November 20, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants