Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade to latest Tapir version #1417

Merged
merged 5 commits into from
Oct 29, 2024
Merged

chore: upgrade to latest Tapir version #1417

merged 5 commits into from
Oct 29, 2024

Conversation

bvoiturier
Copy link
Contributor

The version of the Tapir library used in the cloud agent to implement both the REST API and DIDComm endpoints is outdated. We should upgrade to the current latest version => 1.11.7

Copy link
Contributor

github-actions bot commented Oct 25, 2024

Unit Test Results

103 files  ±0  103 suites  ±0   21m 2s ⏱️ +44s
876 tests ±0  868 ✅ ±0  8 💤 ±0  0 ❌ ±0 
883 runs  ±0  875 ✅ ±0  8 💤 ±0  0 ❌ ±0 

Results for commit c7867ba. ± Comparison against base commit 43b65b6.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Oct 25, 2024

Integration Test Results

20 files  ±0  20 suites  ±0   3s ⏱️ ±0s
52 tests ±0  52 ✅ ±0  0 💤 ±0  0 ❌ ±0 
93 runs  ±0  93 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit c7867ba. ± Comparison against base commit 43b65b6.

♻️ This comment has been updated with latest results.

Signed-off-by: Benjamin Voiturier <[email protected]>
@bvoiturier bvoiturier changed the title Upgrade to latest Tapir version chore: upgrade to latest Tapir version Oct 25, 2024
@coveralls
Copy link

coveralls commented Oct 25, 2024

Coverage Status

coverage: 48.438% (-0.3%) from 48.741%
when pulling c7867ba on chore/tapir-upgrade
into 43b65b6 on main.

@bvoiturier
Copy link
Contributor Author

I tried to replace the transitive scala-uri dependency but couldn't find a decent alternative. The cloud agent uses the scala-uri library for some sensitive operations like parsing and normalizing Prism DIDs, or parsing and resolving URI/URL resources. Re-implementing ourselves would probably be risky and time-consuming.

So I decided, at this stage, to just force scala-uri to use cats-parse:1.0.0 in order to avoid dependency conflicts with the latest version of Tapir that transitively depends on it.

@bvoiturier bvoiturier merged commit 228f07b into main Oct 29, 2024
13 of 14 checks passed
@bvoiturier bvoiturier deleted the chore/tapir-upgrade branch October 29, 2024 10:26
Copy link
Contributor

@mineme0110 mineme0110 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -114,7 +114,10 @@ lazy val D = new {
val tapirPrometheusMetrics: ModuleID = "com.softwaremill.sttp.tapir" %% "tapir-prometheus-metrics" % V.tapir
val micrometer: ModuleID = "io.micrometer" % "micrometer-registry-prometheus" % V.micrometer
val micrometerPrometheusRegistry = "io.micrometer" % "micrometer-core" % V.micrometer
val scalaUri = "io.lemonlabs" %% "scala-uri" % V.scalaUri
val scalaUri = Seq(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bvoiturier, I think we need to find a replacement for this library.
It's not actively maintained and might cause conflicts as we upgrade other libraries.
https://github.com/lemonlabsuk/scala-uri

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the tapir library from 1.6.4 to 1.11.2 version Replace scala-uri library from the project
6 participants