Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Retroactively sign off on previous commits #1397

Closed
wants to merge 1 commit into from

Conversation

mineme0110
Copy link
Contributor

@mineme0110 mineme0110 commented Oct 17, 2024

Description:

Summarize the changes you're submitting in a few sentences, including Jira ticket ATL-xxxx if applicable.
Link to any discussion, related issues and bug reports to give the context to help the reviewer understand the PR.

Alternatives Considered (optional):

Link to existing ADR (Architecture Decision Record), if any. If relevant, describe other approaches explored and the selected approach. Documenting why the methods were not selected will create a knowledge base for future reference, helping prevent others from revisiting less optimal ideas.

Checklist:

  • My PR follows the contribution guidelines of this project
  • My PR is free of third-party dependencies that don't comply with the Allowlist
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked the PR title to follow the conventional commit specification

@mineme0110 mineme0110 requested a review from a team as a code owner October 17, 2024 12:02
@mineme0110 mineme0110 requested a review from yshyn-iohk October 17, 2024 12:02
@mineme0110 mineme0110 changed the title Retroactively sign off on previous commits fix: Retroactively sign off on previous commits Oct 17, 2024
Copy link
Contributor

Integration Test Results

20 files  ±0  20 suites  ±0   3s ⏱️ ±0s
51 tests ±0  51 ✅ ±0  0 💤 ±0  0 ❌ ±0 
90 runs  ±0  90 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit ce8bed4. ± Comparison against base commit f74cc3e.

@mineme0110 mineme0110 closed this Oct 17, 2024
@mineme0110 mineme0110 deleted the fix-signoff-old-commits branch October 17, 2024 12:14
@coveralls
Copy link

Coverage Status

coverage: 48.578%. remained the same
when pulling ce8bed4 on fix-signoff-old-commits
into f74cc3e on main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants