build: make sure -Dquill.macro.log=false is passed when quill compiles #1264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pat Losoponkul <[email protected]>
Integration Test Results19 files 19 suites 2s ⏱️ Results for commit d565711. |
Unit Test Results 96 files 96 suites 21m 51s ⏱️ Results for commit d565711. |
yshyn-iohk
approved these changes
Jul 12, 2024
shotexa
pushed a commit
that referenced
this pull request
Jul 17, 2024
#1264) Signed-off-by: Pat Losoponkul <[email protected]> Signed-off-by: Shota Jolbordi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR make sure quill pick up the
quill.macro.log=falseflag. This remove a all of static query logs. However this does not make the log ofDynamic Query Detected ...logs disappeared. It would require a change in the library here.Alternatives Considered (optional):
Link to existing ADR (Architecture Decision Record), if any. If relevant, describe other approaches explored and the selected approach. Documenting why the methods were not selected will create a knowledge base for future reference, helping prevent others from revisiting less optimal ideas.
Checklist: