Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid name and operationId conflict when creating oas client #1233

Merged
merged 1 commit into from
Jun 28, 2024
Merged

fix: avoid name and operationId conflict when creating oas client #1233

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...ice/server/src/main/scala/org/hyperledger/identus/oid4vci/CredentialIssuerEndpoints.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ object CredentialIssuerEndpoints {
)
.out(jsonBody[CredentialResponse])
.errorOut(credentialEndpointErrorOutput)
.name("issueCredential")
.name("oid4vciIssueCredential")
.summary("Credential Endpoint")
.description(
"""OID for VCI [Credential Endpoint](https://openid.net/specs/openid-4-verifiable-credential-issuance-1_0.html#name-credential-endpoint)""".stripMargin
Expand All @@ -97,7 +97,7 @@ object CredentialIssuerEndpoints {
)
.out(jsonBody[CredentialOfferResponse])
.errorOut(EndpointOutputs.basicFailureAndNotFoundAndForbidden)
.name("createCredentialOffer")
.name("oid4vciCreateCredentialOffer")
.summary("Create a new credential offer")
.description(
"""Create a new credential offer and return a compliant `CredentialOffer` for the holder's
Expand Down
6 changes: 5 additions & 1 deletion .../server/src/main/scala/org/hyperledger/identus/oid4vci/http/CredentialErrorResponse.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,11 @@ import scala.util.Try
type ExtendedErrorResponse = ErrorResponse | CredentialErrorResponse

object ExtendedErrorResponse {
given schema: Schema[ExtendedErrorResponse] = Schema.schemaForEither[ErrorResponse, CredentialErrorResponse].as
given schema: Schema[ExtendedErrorResponse] =
Schema
.schemaForEither[ErrorResponse, CredentialErrorResponse]
.name(Schema.SName("ExtendedErrorResponse"))
.as
given encoder: JsonEncoder[ExtendedErrorResponse] =
ErrorResponse.encoder
.orElseEither(CredentialErrorResponse.encoder)
Expand Down
Loading