Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update docs for JWT revocation [skip ci] #1167

Merged
merged 5 commits into from
Jun 14, 2024

Conversation

shotexa
Copy link
Contributor

@shotexa shotexa commented Jun 10, 2024

Description:

Update JWT revocation docs following the update in implementation introduced by this PR
For ATL-7193

Checklist:

  • My PR follows the contribution guidelines of this project
  • My PR is free of third-party dependencies that don't comply with the Allowlist
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked the PR title to follow the conventional commit specification

Signed-off-by: Shota Jolbordi <[email protected]>
Copy link
Contributor

github-actions bot commented Jun 10, 2024

Integration Test Results

15 files  ±0  15 suites  ±0   2s ⏱️ ±0s
33 tests ±0  33 ✅ ±0  0 💤 ±0  0 ❌ ±0 
46 runs  ±0  46 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit ef93e89. ± Comparison against base commit 65da651.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Jun 10, 2024

Unit Test Results

 92 files  ±0   92 suites  ±0   21m 10s ⏱️ -8s
782 tests ±0  774 ✅ ±0  8 💤 ±0  0 ❌ ±0 
789 runs  ±0  781 ✅ ±0  8 💤 ±0  0 ❌ ±0 

Results for commit ef93e89. ± Comparison against base commit 65da651.

♻️ This comment has been updated with latest results.

Copy link
Member

@yshyn-iohk yshyn-iohk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job!

@yshyn-iohk
Copy link
Member

@shotexa, you need to merge the megalinter fixes from this PR
And if you add [skip ci] to the PR title, the build will pass much faster ;)

Signed-off-by: Hyperledger Bot <[email protected]>
Co-authored-by: Hyperledger Bot <[email protected]>
@shotexa
Copy link
Contributor Author

shotexa commented Jun 10, 2024

@shotexa, you need to merge the megalinter fixes from this PR And if you add [skip ci] to the PR title, the build will pass much faster ;)

Thanks, is this a new flow we have now? GitHub actions opening a PR with linter fixes which we have to merge manually?

@yshyn-iohk yshyn-iohk changed the title docs: update docs for JWT revocation docs: update docs for JWT revocation [skip ci] Jun 11, 2024
@yshyn-iohk yshyn-iohk enabled auto-merge (squash) June 14, 2024 10:18
@yshyn-iohk yshyn-iohk merged commit 1ed1d6c into main Jun 14, 2024
8 checks passed
@yshyn-iohk yshyn-iohk deleted the ATL-7193-update-jwt-revocation-docs branch June 14, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants