-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update website link to Identus #1096
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Breuninger <[email protected]>
Signed-off-by: mkbreuning <[email protected]>
Integration Test Results15 files 15 suites 2s ⏱️ Results for commit ccb28e8. ♻️ This comment has been updated with latest results. |
Unit Test Results 91 files 91 suites 20m 49s ⏱️ Results for commit ccb28e8. ♻️ This comment has been updated with latest results. |
yshyn-iohk
approved these changes
May 23, 2024
patlo-iog
pushed a commit
that referenced
this pull request
Jun 13, 2024
Signed-off-by: Michael Breuninger <[email protected]> Signed-off-by: mkbreuning <[email protected]> Signed-off-by: Pat Losoponkul <[email protected]>
patlo-iog
pushed a commit
that referenced
this pull request
Jun 13, 2024
Signed-off-by: Yurii Shynbuiev <[email protected]> Signed-off-by: Pat Losoponkul <[email protected]> feat(agent): implement Nonce stub endpoint for OIDC credential issuer Signed-off-by: Yurii Shynbuiev <[email protected]> Signed-off-by: Pat Losoponkul <[email protected]> feat(agent): add CredentialIssuerService mock and get walletId by prism DID method Signed-off-by: Yurii Shynbuiev <[email protected]> Signed-off-by: Pat Losoponkul <[email protected]> feat(agent): implement the VC issuance flow with the dummy data Signed-off-by: Yurii Shynbuiev <[email protected]> Signed-off-by: Pat Losoponkul <[email protected]> feat(agent): implement the VC issuance flow with the dummy data Signed-off-by: Yurii Shynbuiev <[email protected]> Signed-off-by: Pat Losoponkul <[email protected]> feat: credential offer endpoint and keycloak plugin wip (#935) Signed-off-by: Pat Losoponkul <[email protected]> feat(agent): add IssuanceSession and NonceService Signed-off-by: Yurii Shynbuiev <[email protected]> Signed-off-by: Pat Losoponkul <[email protected]> docs: add example instruction how to run Signed-off-by: Pat Losoponkul <[email protected]> fix: integrate oidc4vc CredentialOffer to IssuanceSession (#943) Signed-off-by: Pat Losoponkul <[email protected]> doc(agent): add the details to the readme.md and change the port of the mock server Signed-off-by: Yurii Shynbuiev <[email protected]> Signed-off-by: Pat Losoponkul <[email protected]> chore: resolve rebase conflict Signed-off-by: Pat Losoponkul <[email protected]> chore: resolve rebase conflict Signed-off-by: Pat Losoponkul <[email protected]> chore: resolve merge compilation conflict Signed-off-by: Pat Losoponkul <[email protected]> feat: oidc4vc issuer metadata and credential configuration CRUD (#977) Signed-off-by: Kranium Gikos Mendoza <[email protected]> Co-authored-by: womfoo <[email protected]> Signed-off-by: Pat Losoponkul <[email protected]> test: fix test layer make it pass Signed-off-by: Pat Losoponkul <[email protected]> chore: resolve rename conflicts Signed-off-by: Pat Losoponkul <[email protected]> chore: resolve rename conflicts Signed-off-by: Pat Losoponkul <[email protected]> chore: clean duplicate imports Signed-off-by: Pat Losoponkul <[email protected]> docs: delete the architecture folder [skip ci] (#996) Signed-off-by: Yurii Shynbuiev <[email protected]> Signed-off-by: Pat Losoponkul <[email protected]> docs: update the references to the Cloud Agent in the documentation and tutorials (#995) Signed-off-by: Yurii Shynbuiev <[email protected]> Signed-off-by: Pat Losoponkul <[email protected]> ci: switch linter workflows to the Hyperledger CI (#997) Signed-off-by: Yurii Shynbuiev <[email protected]> Signed-off-by: Pat Losoponkul <[email protected]> ci: fix scala-steward after moving repo to hyperledger (#993) Signed-off-by: Pat Losoponkul <[email protected]> fix: expose pg_admin port on the localhost interface only (#957) Signed-off-by: Roberto Carvajal <[email protected]> Co-authored-by: Yurii Shynbuiev - IOHK <[email protected]> Signed-off-by: Pat Losoponkul <[email protected]> ci: cloud-agent OAS breaking change detection (#1000) Signed-off-by: Yurii Shynbuiev <[email protected]> Signed-off-by: Pat Losoponkul <[email protected]> ci: fix megalinter PR creation (#1003) Signed-off-by: Yurii Shynbuiev <[email protected]> Signed-off-by: Pat Losoponkul <[email protected]> docs: cleanup other prism term entries (#1001) Signed-off-by: Yurii Shynbuiev <[email protected]> Signed-off-by: Yurii Shynbuiev - IOHK <[email protected]> Signed-off-by: Hyperledger Bot <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Hyperledger Bot <[email protected]> Signed-off-by: Pat Losoponkul <[email protected]> chore: update Coveralls badge [skip ci] (#1005) Signed-off-by: Yurii Shynbuiev - IOHK <[email protected]> Signed-off-by: Hyperledger Bot <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Hyperledger Bot <[email protected]> Signed-off-by: Pat Losoponkul <[email protected]> docs: improve OAS docs for Event and IAM section (#1007) Signed-off-by: Pat Losoponkul <[email protected]> Co-authored-by: Yurii Shynbuiev - IOHK <[email protected]> Signed-off-by: Pat Losoponkul <[email protected]> fix: Fix OneOf OpenAPI Serialization Issue (#1010) Signed-off-by: Bassam Riman <[email protected]> Signed-off-by: Pat Losoponkul <[email protected]> fix: remove prism-crypto dependency (#1015) Signed-off-by: Pat Losoponkul <[email protected]> ci: semantic-release upgrade, oasdiff fix (#1017) Signed-off-by: Yurii Shynbuiev <[email protected]> Signed-off-by: Pat Losoponkul <[email protected]> chore(release): cut Identus Cloud agent 1.32.1 release * expose pg_admin port on the localhost interface only ([#957](#957)) ([73674b5](73674b5)) * Fix OneOf OpenAPI Serialization Issue ([#1010](#1010)) ([393c296](393c296)) * remove prism-crypto dependency ([#1015](#1015)) ([46e594c](46e594c)) * update open-api-spec and generator script and package.json ([#990](#990)) ([88c1b5e](88c1b5e)) Signed-off-by: Allain Magyar <[email protected]> Signed-off-by: Pat Losoponkul <[email protected]> fix: integration test (#1011) Signed-off-by: Bassam Riman <[email protected]> Signed-off-by: Yurii Shynbuiev - IOHK <[email protected]> Co-authored-by: Yurii Shynbuiev - IOHK <[email protected]> Signed-off-by: Pat Losoponkul <[email protected]> feat: oid4vci credential configuration and metadata endpoints (#1021) Signed-off-by: Pat Losoponkul <[email protected]> feat: rename `prism-agent` to `cloud-agent` (#1019) Signed-off-by: Yurii Shynbuiev <[email protected]> Signed-off-by: Hyperledger Bot <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Hyperledger Bot <[email protected]> Signed-off-by: Pat Losoponkul <[email protected]> chore(release): cut Identus Cloud agent 1.33.0 release * integration test ([#1011](#1011)) ([d674f31](d674f31)) * rename `prism-agent` to `cloud-agent` ([#1019](#1019)) ([74560da](74560da)) Signed-off-by: Allain Magyar <[email protected]> Signed-off-by: Pat Losoponkul <[email protected]> test: add tests for oid4vci credential configuration CRUD (#1027) Signed-off-by: Pat Losoponkul <[email protected]> chore: update OID4VCI example script to use issuer metadata (#1036) Signed-off-by: Pat Losoponkul <[email protected]> Merge branch main into oidc Signed-off-by: Pat Losoponkul <[email protected]> test: add tests for the new key types (#1044) Signed-off-by: Pat Losoponkul <[email protected]> fix: expose new key types in rest api (#1066) Signed-off-by: Pat Losoponkul <[email protected]> docs: rename ADRs in the scope of rebranding to the Identus ATL-7050 (#1053) Signed-off-by: Yurii Shynbuiev <[email protected]> Signed-off-by: Pat Losoponkul <[email protected]> ci: fix scala steward DCO signature (#1057) Signed-off-by: Yurii Shynbuiev <[email protected]> Signed-off-by: Hyperledger Bot <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Hyperledger Bot <[email protected]> Signed-off-by: Pat Losoponkul <[email protected]> chore(release): cut Identus Cloud agent 1.33.1 release * broken link for the cloud agent packages in readme file ([#1032](#1032)) ([92d17c2](92d17c2)) * expose new key types in rest api ([#1066](#1066)) ([9ce8d3a](9ce8d3a)) * rename the folder to identus for vc-jwt ([#1063](#1063)) ([364a5dc](364a5dc)) * update ts client in the performance tests, cleanup `println` ([#1041](#1041)) ([7d5ceba](7d5ceba)) Signed-off-by: Allain Magyar <[email protected]> Signed-off-by: Pat Losoponkul <[email protected]> test: add DID Registrar test scenario to use new key types (#1071) Signed-off-by: Pat Losoponkul <[email protected]> ci: scala steward DCO by hardcoding the message (#1074) Signed-off-by: Yurii Shynbuiev <[email protected]> Signed-off-by: Pat Losoponkul <[email protected]> chore(deps): bump requests from 2.26.0 to 2.32.0 in /infrastructure/utils/python/github-helpers in the pip group across 1 directory (#1070) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Yurii Shynbuiev - IOHK <[email protected]> Signed-off-by: Pat Losoponkul <[email protected]> ci: use branch name in pre-release version name (#1080) Signed-off-by: Pat Losoponkul <[email protected]> docs: rebranding to the Identus, OEA->ICA (#1081) Signed-off-by: Yurii Shynbuiev <[email protected]> Signed-off-by: Yurii Shynbuiev - IOHK <[email protected]> Signed-off-by: Hyperledger Bot <[email protected]> Co-authored-by: Pete Vielhaber <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Hyperledger Bot <[email protected]> Signed-off-by: Pat Losoponkul <[email protected]> docs: add identus logo to README.md [skip ci] (#1084) Signed-off-by: Yurii Shynbuiev <[email protected]> Signed-off-by: Pat Losoponkul <[email protected]> build: protobuf dependency update (#1077) Signed-off-by: Hyperledger Bot <[email protected]> Co-authored-by: Hyperledger Bot <[email protected]> Co-authored-by: Yurii Shynbuiev - IOHK <[email protected]> Signed-off-by: Pat Losoponkul <[email protected]> build: internal dependency updates (#1079) Signed-off-by: Hyperledger Bot <[email protected]> Co-authored-by: Hyperledger Bot <[email protected]> Co-authored-by: Yurii Shynbuiev - IOHK <[email protected]> Co-authored-by: patlo-iog <[email protected]> Signed-off-by: Pat Losoponkul <[email protected]> build: sbt and plugins dependency update (#1078) Signed-off-by: Hyperledger Bot <[email protected]> Co-authored-by: Hyperledger Bot <[email protected]> Co-authored-by: patlo-iog <[email protected]> Signed-off-by: Pat Losoponkul <[email protected]> docs: update new key types in DID tutorials [skip ci] (#1085) Signed-off-by: Pat Losoponkul <[email protected]> build: DAL dependency update (#1076) Signed-off-by: Hyperledger Bot <[email protected]> Signed-off-by: Pat Losoponkul <[email protected]> Co-authored-by: Hyperledger Bot <[email protected]> Co-authored-by: patlo-iog <[email protected]> Signed-off-by: Pat Losoponkul <[email protected]> docs: Add ADR for resources storage (#1087) Signed-off-by: EzequielPostan <[email protected]> Signed-off-by: Pat Losoponkul <[email protected]> test: add jwt revocation test scenario (#951) Signed-off-by: Allain Magyar <[email protected]> Signed-off-by: Hyperledger Bot <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Hyperledger Bot <[email protected]> Signed-off-by: Pat Losoponkul <[email protected]> ci: fail megalinter check when there are autofixes (#1092) Signed-off-by: Yurii Shynbuiev <[email protected]> Signed-off-by: Pat Losoponkul <[email protected]> chore: fix slack notification message tag (#1091) Signed-off-by: Allain Magyar <[email protected]> Co-authored-by: Yurii Shynbuiev - IOHK <[email protected]> Signed-off-by: Pat Losoponkul <[email protected]> docs: update the architecture diagram and typos in ADRs [skip ci] (#1093) Signed-off-by: Yurii Shynbuiev <[email protected]> Signed-off-by: Pat Losoponkul <[email protected]> ci: fail the build when the megalinter found the issues [skip ci] (#1095) Signed-off-by: Yurii Shynbuiev <[email protected]> Signed-off-by: Pat Losoponkul <[email protected]> docs: update website link to Identus (#1096) Signed-off-by: Michael Breuninger <[email protected]> Signed-off-by: mkbreuning <[email protected]> Signed-off-by: Pat Losoponkul <[email protected]> fix: integrate issuer metadata in oid4vci credential endpoint (#1105) Signed-off-by: Pat Losoponkul <[email protected]> ci: fix linter warnings (#1109) Signed-off-by: Pat Losoponkul <[email protected]> feat: Rename helm chart and its resources (#1104) Signed-off-by: Milos Backonja <[email protected]> Signed-off-by: Pat Losoponkul <[email protected]> chore(release): cut Identus Cloud agent 1.34.0 release * Rename helm chart and its resources ([#1104](#1104)) ([84c5cea](84c5cea)) Signed-off-by: Allain Magyar <[email protected]> Signed-off-by: Pat Losoponkul <[email protected]> feat: integrate SD JWT (#1016) Signed-off-by: FabioPinheiro <[email protected]> Signed-off-by: mineme0110 <[email protected]> Co-authored-by: mineme0110 <[email protected]> build: sbt and plugins dependency update (#1102) Signed-off-by: Hyperledger Bot <[email protected]> Co-authored-by: Hyperledger Bot <[email protected]> Co-authored-by: Yurii Shynbuiev - IOHK <[email protected]> Signed-off-by: Pat Losoponkul <[email protected]> test: updates integration test tags (#1098) Signed-off-by: Allain Magyar <[email protected]> Co-authored-by: Yurii Shynbuiev - IOHK <[email protected]> Signed-off-by: Pat Losoponkul <[email protected]> feat(agent): ATL-6839 migrate DIDComm endpoint to tapir (#1116) Signed-off-by: Benjamin Voiturier <[email protected]> Resolve merge conflicts Signed-off-by: Pat Losoponkul <[email protected]> fix: re-number migration Signed-off-by: Pat Losoponkul <[email protected]> ci: switch to the GitHub runners (#1121) Signed-off-by: Yurii Shynbuiev <[email protected]> Signed-off-by: Pat Losoponkul <[email protected]> chore: scalafmt import rewrite (#1120) Signed-off-by: Pat Losoponkul <[email protected]> fix: VC Verification API Doc (#1118) Signed-off-by: Bassam Riman <[email protected]> Co-authored-by: Yurii Shynbuiev - IOHK <[email protected]> Signed-off-by: Pat Losoponkul <[email protected]> fix: SemanticCheckOfClaims In Verification API (#1124) Signed-off-by: Bassam Riman <[email protected]> Signed-off-by: Pat Losoponkul <[email protected]> ci: revert switch to the GitHub runners (#1123) Signed-off-by: Pat Losoponkul <[email protected]> fix: update the jose dependency and switch back to the official library (#1117) Signed-off-by: mineme0110 <[email protected]> Signed-off-by: Pat Losoponkul <[email protected]> fix: make oidc local script work (#1131) Signed-off-by: Pat Losoponkul <[email protected]> feat: authentication for oid4vci credential and nonce endpoint (#1148) Signed-off-by: Pat Losoponkul <[email protected]> fix: update issuer auth server model parity (#1154) Signed-off-by: Pat Losoponkul <[email protected]> feat(agent): validate JWT proof in the credential request, update dem… (#1165) Signed-off-by: Yurii Shynbuiev <[email protected]> Signed-off-by: Hyperledger Bot <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Hyperledger Bot <[email protected]> feat: add claims to the VC (#1176) Signed-off-by: Yurii Shynbuiev <[email protected]> Signed-off-by: Pat Losoponkul <[email protected]> chore: migrate oid4vci example to published keycloak plugin (#1174) Signed-off-by: Pat Losoponkul <[email protected]> fix: add claims validation when creating oid4vci credential offer (#1178) Signed-off-by: Pat Losoponkul <[email protected]> fix: Changing .chart.name reference, adding name override (#1129) Signed-off-by: Milos Backonja <[email protected]> Signed-off-by: Pat Losoponkul <[email protected]> chore(release): cut Identus Cloud agent 1.35.0 release * SemanticCheckOfClaims In Verification API ([#1124](#1124)) ([7cb4192](7cb4192)) * update the jose dependency and switch back to the official library ([#1117](#1117)) ([3608aaf](3608aaf)) * Changing .chart.name reference, adding name override ([#1129](#1129)) ([650ae3b](650ae3b)) * VC Verification API Doc ([#1118](#1118)) ([d70d4b7](d70d4b7)) * **agent:** ATL-6839 migrate DIDComm endpoint to tapir ([#1116](#1116)) ([2f4f7c3](2f4f7c3)) * integrate SD JWT ([#1016](#1016)) ([9d7948f](9d7948f)) Signed-off-by: Allain Magyar <[email protected]> Signed-off-by: Pat Losoponkul <[email protected]> docs(agent): Regenerate PNG images from updated PUML files (#1128) Signed-off-by: Benjamin Voiturier <[email protected]> Signed-off-by: Pat Losoponkul <[email protected]> fix: Add expiration time for cloud-agent (#1132) Signed-off-by: mineme0110 <[email protected]> Signed-off-by: Pat Losoponkul <[email protected]> style: remove deprecated Scala syntax (#1134) Signed-off-by: FabioPinheiro <[email protected]> fix: Chart refactor (#1143) Signed-off-by: Milos Backonja <[email protected]> Signed-off-by: Pat Losoponkul <[email protected]> chore(release): cut Identus Cloud agent 1.35.1 release * Add expiration time for cloud-agent ([#1132](#1132)) ([f719120](f719120)) * Chart refactor ([#1143](#1143)) ([f309a0e](f309a0e)) Signed-off-by: Allain Magyar <[email protected]> Signed-off-by: Pat Losoponkul <[email protected]> ci: add custom DCO check action [skip ci] (#1142) Signed-off-by: Pat Losoponkul <[email protected]> fix: Schema Error Handling (#1138) Signed-off-by: Bassam Riman <[email protected]> Signed-off-by: Pat Losoponkul <[email protected]> ci: revert custom DCO check action [skip ci] (#1147) Signed-off-by: Pat Losoponkul <[email protected]> test: add checks for prism did creation (#1144) Signed-off-by: Allain Magyar <[email protected]> Signed-off-by: Hyperledger Bot <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Hyperledger Bot <[email protected]> Co-authored-by: Yurii Shynbuiev - IOHK <[email protected]> Signed-off-by: Pat Losoponkul <[email protected]> style: remove unused imports (#1135) Signed-off-by: FabioPinheiro <[email protected]> docs: updating the hdkey ADR [skip ci] (#1149) Signed-off-by: Hyperledger Bot <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Hyperledger Bot <[email protected]> Signed-off-by: Pat Losoponkul <[email protected]> feat: improve ZIO failures and defects in credential definition (#1133) Signed-off-by: FabioPinheiro <[email protected]> Signed-off-by: Pat Losoponkul <[email protected]> fix: Credential Defintion Error Handling Part 2 (#1155) Signed-off-by: Bassam Riman <[email protected]> Signed-off-by: Pat Losoponkul <[email protected]> fix: Credential Defintion Error Handling Part 2 (#1156) Signed-off-by: Bassam Riman <[email protected]> Signed-off-by: Pat Losoponkul <[email protected]> feat: Remove double Error logs in DIDController (#1140) fix: pick right key type when creating corresponding issuer (#1157) Signed-off-by: Pat Losoponkul <[email protected]> build: internal dependency updates (#1126) Signed-off-by: Hyperledger Bot <[email protected]> Signed-off-by: Pat Losoponkul <[email protected]> Co-authored-by: Hyperledger Bot <[email protected]> Co-authored-by: patlo-iog <[email protected]> Signed-off-by: Pat Losoponkul <[email protected]> fix: Update the Holder to send the presentation only, No claims to disclose is needed separately (#1158) Signed-off-by: mineme0110 <[email protected]> Signed-off-by: Pat Losoponkul <[email protected]> fix: Helm chart refactor (#1160) Signed-off-by: Milos Backonja <[email protected]> Signed-off-by: Pat Losoponkul <[email protected]> chore(release): cut Identus Cloud agent 1.36.0 release * Credential Defintion Error Handling Part 2 ([#1155](#1155)) ([2df5306](2df5306)) * Credential Defintion Error Handling Part 2 ([#1156](#1156)) ([5755504](5755504)) * Helm chart refactor ([#1160](#1160)) ([4b59112](4b59112)) * pick right key type when creating corresponding issuer ([#1157](#1157)) ([22f0448](22f0448)) * Schema Error Handling ([#1138](#1138)) ([a9da840](a9da840)) * Update the Holder to send the presentation only, No claims to disclose is needed separately ([#1158](#1158)) ([9eaa5d4](9eaa5d4)) * improve ZIO failures and defects in credential definition ([#1133](#1133)) ([d6dfb72](d6dfb72)) * Remove double Error logs in DIDController ([#1140](#1140)) ([888ebb4](888ebb4)) Signed-off-by: Allain Magyar <[email protected]> Signed-off-by: Pat Losoponkul <[email protected]> fix: Helm chart refactor vol2 (#1162) Signed-off-by: Milos Backonja <[email protected]> Signed-off-by: Pat Losoponkul <[email protected]> chore(release): cut Identus Cloud agent 1.36.1 release * Helm chart refactor vol2 ([#1162](#1162)) ([72fc6d1](72fc6d1)) Signed-off-by: Allain Magyar <[email protected]> Signed-off-by: Pat Losoponkul <[email protected]> feat: ATL-6834 Use ZIO Failures and Defects effectively in the Issue flow (#1139) Signed-off-by: Benjamin Voiturier <[email protected]> feat: use the compact format in SD-JWT (#1169) Signed-off-by: Pat Losoponkul <[email protected]> fix: Present Error Handling (Part 1: Repo Changes) (#1172) Signed-off-by: Bassam Riman <[email protected]> Signed-off-by: Pat Losoponkul <[email protected]> feat: ATL 6829 - Integrate ZIO failures and defects ADR in credential status list (#1175) Signed-off-by: Benjamin Voiturier <[email protected]> Signed-off-by: Pat Losoponkul <[email protected]> fix: resolve merge conflict and error interface chore: use latest snaptshot version for example Signed-off-by: Pat Losoponkul <[email protected]> style: fix and fmt Signed-off-by: Pat Losoponkul <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Checklist: