Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: oid4vci endpoints error statuses and negative input validation #1384

Merged
merged 5 commits into from
Sep 30, 2024

Conversation

patlo-iog
Copy link
Contributor

ATL-7838
ATL-7839
ATL-7847

@patlo-iog patlo-iog requested a review from a team as a code owner September 27, 2024 09:15
@patlo-iog patlo-iog changed the title fix: oid4vci error statuses and negative input validation fix: oid4vci endpoints error statuses and negative input validation Sep 27, 2024
@patlo-iog patlo-iog force-pushed the fix/oid4vci-qa branch 2 times, most recently from e9fd21e to 40c359f Compare September 27, 2024 09:20
Copy link
Contributor

github-actions bot commented Sep 27, 2024

Integration Test Results

20 files  ±0  20 suites  ±0   2s ⏱️ ±0s
45 tests ±0  45 ✅ ±0  0 💤 ±0  0 ❌ ±0 
71 runs  ±0  71 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit c362e77. ± Comparison against base commit 658e094.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Sep 27, 2024

Unit Test Results

102 files  ±0  102 suites  ±0   19m 41s ⏱️ +25s
872 tests ±0  864 ✅ ±0  8 💤 ±0  0 ❌ ±0 
879 runs  ±0  871 ✅ ±0  8 💤 ±0  0 ❌ ±0 

Results for commit c362e77. ± Comparison against base commit 658e094.

♻️ This comment has been updated with latest results.

@coveralls
Copy link

coveralls commented Sep 27, 2024

Coverage Status

coverage: 48.619% (+0.07%) from 48.548%
when pulling c362e77 on fix/oid4vci-qa
into 658e094 on main.

@patlo-iog patlo-iog added the autoupdate Merge the main branch into a feature branch label Sep 27, 2024
@patlo-iog patlo-iog enabled auto-merge (squash) September 27, 2024 10:27
Copy link
Member

@yshyn-iohk yshyn-iohk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@patlo-iog patlo-iog merged commit 65cc9a7 into main Sep 30, 2024
13 checks passed
@patlo-iog patlo-iog deleted the fix/oid4vci-qa branch September 30, 2024 10:43
bytewizard42i pushed a commit to bytewizard42i/identus-cloud-agent that referenced this pull request Nov 13, 2024
# [1.40.0](hyperledger/identus-cloud-agent@cloud-agent-v1.39.0...cloud-agent-v1.40.0) (2024-11-05)

### Bug Fixes

* Add key_id missing field ([hyperledger#1403](hyperledger#1403)) ([cbd1a03](hyperledger@cbd1a03))
* adjust Kotlin and TypeScript HTTP client to use the `schemaId` f… ([hyperledger#1388](hyperledger#1388)) ([c2da492](hyperledger@c2da492))
* cannot reuse the same credential-offer in oid4vci ([hyperledger#1361](hyperledger#1361)) ([6a0a3ea](hyperledger@6a0a3ea))
* handle unsupported PIURI found in DIDComm messages accordingly ([hyperledger#1399](hyperledger#1399)) ([9b64793](hyperledger@9b64793))
* key id for jwt and sdjwt ([hyperledger#1420](hyperledger#1420)) ([5830a7e](hyperledger@5830a7e))
* oas to use any schema for json ast node ([hyperledger#1372](hyperledger#1372)) ([95d328e](hyperledger@95d328e))
* oid4vci endpoints error statuses and negative input validation ([hyperledger#1384](hyperledger#1384)) ([65cc9a7](hyperledger@65cc9a7))
* Preserve Presentation Format ([hyperledger#1363](hyperledger#1363)) ([c18385c](hyperledger@c18385c))
* return 404 when create credConfig on non-existing issuer ([hyperledger#1379](hyperledger#1379)) ([e532ba6](hyperledger@e532ba6))

### Features

* Add KID to the credential-offers API - ATL-7704 ([hyperledger#1320](hyperledger#1320)) ([56200cf](hyperledger@56200cf))
* add presentation-exchange endpoints ([hyperledger#1365](hyperledger#1365)) ([49f7ab3](hyperledger@49f7ab3))
* ATL-6983 ZIO Stream Kafka PoC in background jobs ([hyperledger#1339](hyperledger#1339)) ([19ab426](hyperledger@19ab426))
* Default Backend API to Array Of Credential Schema ([hyperledger#1366](hyperledger#1366)) ([693dcc4](hyperledger@693dcc4))
* Default Object As Issuer ([hyperledger#1349](hyperledger#1349)) ([d29eebb](hyperledger@d29eebb))
* Implement prism anoncreds method for schemas and credential definitions ([hyperledger#1385](hyperledger#1385)) ([fbee055](hyperledger@fbee055))
* Issuer Replace Either By Union Type ([hyperledger#1374](hyperledger#1374)) ([8fc2fe3](hyperledger@8fc2fe3))
* presentation_submission validation logic ([hyperledger#1332](hyperledger#1332)) ([f80b3c3](hyperledger@f80b3c3))
* Support Array Of Credential Schema ([hyperledger#1351](hyperledger#1351)) ([948e314](hyperledger@948e314))
* Test JWT OBJECT as Issuer ([hyperledger#1343](hyperledger#1343)) ([7208d95](hyperledger@7208d95))
* VC support for Array of credential Status ([hyperledger#1383](hyperledger#1383)) ([ad946cf](hyperledger@ad946cf))
* VCVerification API support ARRAY or OBJECT as Credential Sc… ([hyperledger#1355](hyperledger#1355)) ([91cb4e7](hyperledger@91cb4e7))

 [skip ci]

Signed-off-by: Hyperledger Bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autoupdate Merge the main branch into a feature branch cloud-agent pollux shared
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants