fix: return 404 when create credConfig on non-existing issuer (hyperl…

…edger#1379) Signed-off-by: Pat Losoponkul <[email protected]>
bytewizard42i · Sep 26, 2024 · e532ba6 · e532ba6
1 parent 8fc2fe3
commit e532ba6
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/...main/scala/org/hyperledger/identus/pollux/core/service/OID4VCIIssuerMetadataService.scala b/...main/scala/org/hyperledger/identus/pollux/core/service/OID4VCIIssuerMetadataService.scala
@@ -67,7 +67,7 @@ trait OID4VCIIssuerMetadataService {
       format: CredentialFormat,
       configurationId: String,
       schemaId: String
-  ): ZIO[WalletAccessContext, InvalidSchemaId | UnsupportedCredentialFormat, CredentialConfiguration]
+  ): ZIO[WalletAccessContext, InvalidSchemaId | UnsupportedCredentialFormat | IssuerIdNotFound, CredentialConfiguration]
   def getCredentialConfigurations(
       issuerId: UUID
   ): IO[IssuerIdNotFound, Seq[CredentialConfiguration]]
@@ -127,8 +127,13 @@ class OID4VCIIssuerMetadataServiceImpl(repository: OID4VCIIssuerMetadataReposito
       format: CredentialFormat,
       configurationId: String,
       schemaId: String
-  ): ZIO[WalletAccessContext, InvalidSchemaId | UnsupportedCredentialFormat, CredentialConfiguration] = {
+  ): ZIO[
+    WalletAccessContext,
+    InvalidSchemaId | UnsupportedCredentialFormat | IssuerIdNotFound,
+    CredentialConfiguration
+  ] = {
     for {
+      _ <- getCredentialIssuer(issuerId)
       _ <- format match {
         case CredentialFormat.JWT => ZIO.unit
         case f                    => ZIO.fail(UnsupportedCredentialFormat(f))