fix: SemanticCheckOfClaims In Verification API (#1124)

Signed-off-by: Bassam Riman <[email protected]> Signed-off-by: Pat Losoponkul <[email protected]>
hyperledger · Jun 13, 2024 · f02f205 · f02f205
1 parent 8be5e48
commit f02f205
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/...la/org/hyperledger/identus/verification/controller/VcVerificationControllerImplSpec.scala b/...la/org/hyperledger/identus/verification/controller/VcVerificationControllerImplSpec.scala
@@ -77,6 +77,7 @@ object VcVerificationControllerImplSpec extends ZIOSpecDefault with VcVerificati
             signedJwtCredential.value,
             List(
               ParameterizableVcVerification(VcVerification.SignatureVerification, None),
+              ParameterizableVcVerification(VcVerification.SemanticCheckOfClaims, None),
               ParameterizableVcVerification(VcVerification.NotBeforeCheck, Some(DateTimeParameter(currentTime))),
               ParameterizableVcVerification(VcVerification.ExpirationCheck, Some(DateTimeParameter(currentTime)))
             )
@@ -107,6 +108,7 @@ object VcVerificationControllerImplSpec extends ZIOSpecDefault with VcVerificati
                 signedJwtCredential.value,
                 List(
                   VcVerificationResult(VcVerification.SignatureVerification, false),
+                  VcVerificationResult(VcVerification.SemanticCheckOfClaims, true),
                   VcVerificationResult(VcVerification.NotBeforeCheck, true),
                   VcVerificationResult(VcVerification.ExpirationCheck, true)
                 )

diff --git a/.../org/hyperledger/identus/pollux/core/service/verification/VcVerificationServiceImpl.scala b/.../org/hyperledger/identus/pollux/core/service/verification/VcVerificationServiceImpl.scala
@@ -216,15 +216,15 @@ class VcVerificationServiceImpl(didResolver: DidResolver, uriDereferencer: URIDe
       .as(
         VcVerificationResult(
           credential = credential,
-          verification = VcVerification.SubjectVerification,
+          verification = VcVerification.SemanticCheckOfClaims,
           success = true
         )
       )
       .catchAll(_ =>
         ZIO.succeed(
           VcVerificationResult(
             credential = credential,
-            verification = VcVerification.SubjectVerification,
+            verification = VcVerification.SemanticCheckOfClaims,
             success = false
           )
         )