fix: avoid name and operationId conflict when creating oas client (#1233

) Signed-off-by: Pat Losoponkul <[email protected]>
hyperledger · Jul 1, 2024 · 8fb325c · 8fb325c
1 parent f090554
commit 8fb325c
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/...ice/server/src/main/scala/org/hyperledger/identus/oid4vci/CredentialIssuerEndpoints.scala b/...ice/server/src/main/scala/org/hyperledger/identus/oid4vci/CredentialIssuerEndpoints.scala
@@ -77,7 +77,7 @@ object CredentialIssuerEndpoints {
     )
     .out(jsonBody[CredentialResponse])
     .errorOut(credentialEndpointErrorOutput)
-    .name("issueCredential")
+    .name("oid4vciIssueCredential")
     .summary("Credential Endpoint")
     .description(
       """OID for VCI [Credential Endpoint](https://openid.net/specs/openid-4-verifiable-credential-issuance-1_0.html#name-credential-endpoint)""".stripMargin
@@ -97,7 +97,7 @@ object CredentialIssuerEndpoints {
     )
     .out(jsonBody[CredentialOfferResponse])
     .errorOut(EndpointOutputs.basicFailureAndNotFoundAndForbidden)
-    .name("createCredentialOffer")
+    .name("oid4vciCreateCredentialOffer")
     .summary("Create a new credential offer")
     .description(
       """Create a new credential offer and return a compliant `CredentialOffer` for the holder's

diff --git a/.../server/src/main/scala/org/hyperledger/identus/oid4vci/http/CredentialErrorResponse.scala b/.../server/src/main/scala/org/hyperledger/identus/oid4vci/http/CredentialErrorResponse.scala
@@ -14,7 +14,11 @@ import scala.util.Try
 type ExtendedErrorResponse = ErrorResponse | CredentialErrorResponse
 
 object ExtendedErrorResponse {
-  given schema: Schema[ExtendedErrorResponse] = Schema.schemaForEither[ErrorResponse, CredentialErrorResponse].as
+  given schema: Schema[ExtendedErrorResponse] =
+    Schema
+      .schemaForEither[ErrorResponse, CredentialErrorResponse]
+      .name(Schema.SName("ExtendedErrorResponse"))
+      .as
   given encoder: JsonEncoder[ExtendedErrorResponse] =
     ErrorResponse.encoder
       .orElseEither(CredentialErrorResponse.encoder)